From: Andrew Lunn <andrew@lunn•ch>
To: Benedikt Spranger <b.spranger@linutronix•de>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
netdev@vger•kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Kurt Kanzenbach <kurt@linutronix•de>,
Vivien Didelot <vivien.didelot@gmail•com>
Subject: Re: [RFC PATCH 1/1] Documentation: net: dsa: b53: Describe b53 configuration
Date: Thu, 27 Jun 2019 15:49:29 +0200 [thread overview]
Message-ID: <20190627134929.GE31189@lunn.ch> (raw)
In-Reply-To: <20190627101506.19727-2-b.spranger@linutronix.de>
On Thu, Jun 27, 2019 at 12:15:06PM +0200, Benedikt Spranger wrote:
Hi Benedikt
> +Configuration with tagging support
> +----------------------------------
> +
> +The tagging based configuration is desired.
> +
> +To use the b53 DSA driver some configuration need to be performed. As
> +example configuration the following scenarios are used:
> +
> +*single port*
> + Every switch port acts as a different configurable ethernet port
> +
> +*bridge*
> + Every switch port is part of one configurable ethernet bridge
> +
> +*gateway*
> + Every switch port except one upstream port is part of a configurable
> + ethernet bridge.
> + The upstream port acts as different configurable ethernet port.
> +
> +All configurations are performed with tools from iproute2, wich is available at
> +https://www.kernel.org/pub/linux/utils/net/iproute2/
> +
> +In this documentation the following ethernet ports are used:
> +
> +*eth0*
> + CPU port
In DSA terminology, this is the master interface. The switch port
which the master is connected to is called the CPU port. So you are
causing confusion with DSA terms here.
> +
> +*LAN1*
> + a switch port
> +
> +*LAN2*
> + another switch port
> +
> +*WAN*
> + A switch port dedicated as upstream port
These are all slave interfaces, when using DSA terms.
> +Further ethernet ports can be configured similar.
> +The configured IPs and networks are:
> +
> +*single port*
> + * wan: 192.0.2.1/30 (192.0.2.0 - 192.0.2.3)
> + * lan1: 192.0.2.5/30 (192.0.2.4 - 192.0.2.7)
> + * lan2: 192.0.2.9/30 (192.0.2.8 - 192.0.2.11)
> +
> +*bridge*
> + * br0: 192.0.2.129/25 (192.0.2.128 - 192.0.2.255)
> +
> +*gateway*
> + * br0: 192.0.2.129/25 (192.0.2.128 - 192.0.2.255)
> + * wan: 192.0.2.1/30 (192.0.2.0 - 192.0.2.3)
> +
> +single port
> +~~~~~~~~~~~
> +
> +.. code-block:: sh
> +
> + # configure each interface
> + ip addr add 192.0.2.1/30 dev wan
> + ip addr add 192.0.2.5/30 dev lan1
> + ip addr add 192.0.2.9/30 dev lan2
> +
> + # The master interface needs to be brought up before the slave ports.
> + ip link set eth0 up
> +
> + # bring up the slave interfaces
> + ip link set wan up
> + ip link set lan1 up
> + ip link set lan2 up
> +
> +bridge
> +~~~~~~
> +
> +.. code-block:: sh
> +
> + # create bridge
> + ip link add name br0 type bridge
> +
> + # add ports to bridge
> + ip link set dev wan master br0
> + ip link set dev lan1 master br0
> + ip link set dev lan2 master br0
> +
> + # configure the bridge
> + ip addr add 192.0.2.129/25 dev br0
> +
> + # The master interface needs to be brought up before the slave ports.
> + ip link set eth0 up
> +
> + # bring up the slave interfaces
> + ip link set wan up
> + ip link set lan1 up
> + ip link set lan2 up
I would probably do this in a different order. Bring the master up
first, then the slaves. Then enslave the slaves to bridge, and lastly
configure the bridge.
> +
> + # bring up the bridge
> + ip link set dev br0 up
> +
> +gateway
> +~~~~~~~
> +
> +.. code-block:: sh
> +
> + # create bridge
> + ip link add name br0 type bridge
> +
> + # add ports to bridge
> + ip link set dev lan1 master br0
> + ip link set dev lan2 master br0
> +
> + # configure the bridge
> + ip addr add 192.0.2.129/25 dev br0
> +
> + # configure the upstream port
> + ip addr add 192.0.2.1/30 dev wan
> +
> + # The master interface needs to be brought up before the slave ports.
> + ip link set eth0 up
> +
> + # bring up the slave interfaces
> + ip link set wan up
> + ip link set lan1 up
> + ip link set lan2 up
> +
> + # bring up the bridge
> + ip link set dev br0 up
It would be good to add a note that there is nothing specific to the
B53 here. This same process will work for all DSA drivers which
support tagging, which is actually the majority.
I also tell people that once you configure the master interface up,
they should just use the slave interfaces a normal linux
interfaces. The fact they are on a switch does not matter, and should
not matter. Just use them as normal.
Andrew
next prev parent reply other threads:[~2019-06-27 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 17:57 [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches Benedikt Spranger
2019-06-18 17:57 ` [RFC PATCH 1/2] net: dsa: b53: Turn on managed mode and set IMP port Benedikt Spranger
2019-06-18 18:10 ` Florian Fainelli
2019-06-18 17:57 ` [RFC PATCH 2/2] net: dsa: b53: enbale broadcom tags on bcm531x5 Benedikt Spranger
2019-06-18 18:16 ` [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches Florian Fainelli
2019-06-19 9:18 ` Benedikt Spranger
2019-06-23 2:24 ` Florian Fainelli
2019-06-25 11:20 ` Benedikt Spranger
2019-06-25 18:17 ` Florian Fainelli
2019-06-27 10:15 ` [RFC PATCH 0/1] Document the configuration of b53 Benedikt Spranger
2019-06-27 10:15 ` [RFC PATCH 1/1] Documentation: net: dsa: b53: Describe b53 configuration Benedikt Spranger
2019-06-27 13:49 ` Andrew Lunn [this message]
2019-06-27 14:43 ` Benedikt Spranger
2019-06-27 16:38 ` Florian Fainelli
2019-06-28 11:44 ` Kurt Kanzenbach
2019-06-28 16:57 ` Benedikt Spranger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627134929.GE31189@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=b.spranger@linutronix$(echo .)de \
--cc=bigeasy@linutronix$(echo .)de \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kurt@linutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox