Subject: Re: [PATCH net-next v2 4/4] gve: Add ethtool support

From: Stephen Hemminger <[email-masked]>
Date: Fri, 28 Jun 2019 11:10:52 -0700

On Fri, 28 Jun 2019 10:56:33 -0700
Catherine Sullivan <[email-masked]> wrote:

> +static void
> +gve_get_ethtool_stats(struct net_device *netdev,
> +		      struct ethtool_stats *stats, u64 *data)
> +{
> +	struct gve_priv *priv = netdev_priv(netdev);
> +	u64 rx_pkts, rx_bytes, tx_pkts, tx_bytes;
> +	int ring;
> +	int i;
> +
> +	ASSERT_RTNL();
> +
> +	for (rx_pkts = 0, rx_bytes = 0, ring = 0;
> +	     ring < priv->rx_cfg.num_queues; ring++) {
> +		if (priv->rx) {
> +			rx_pkts += priv->rx[ring].rpackets;
> +			rx_bytes += priv->rx[ring].rbytes;
> +		}
> +	}
> +	for (tx_pkts = 0, tx_bytes = 0, ring = 0;
> +	     ring < priv->tx_cfg.num_queues; ring++) {
> +		if (priv->tx) {
> +			tx_pkts += priv->tx[ring].pkt_done;
> +			tx_bytes += priv->tx[ring].bytes_done;
> +		}
> +	}
> +	memset(data, 0, GVE_MAIN_STATS_LEN * sizeof(*data));

memset here is unnecessary since ethtool_get_stats allocates
and zeros the memory already.