From: Ilias Apalodimas <ilias.apalodimas@linaro•org>
To: Jesper Dangaard Brouer <brouer@redhat•com>
Cc: netdev@vger•kernel.org, jaswinder.singh@linaro•org,
ard.biesheuvel@linaro•org, bjorn.topel@intel•com,
magnus.karlsson@intel•com, daniel@iogearbox•net, ast@kernel•org,
makita.toshiaki@lab•ntt.co.jp, jakub.kicinski@netronome•com,
john.fastabend@gmail•com, davem@davemloft•net,
maciejromanfijalkowski@gmail•com
Subject: Re: [PATCH 3/3, net-next] net: netsec: add XDP support
Date: Fri, 28 Jun 2019 19:47:41 +0300 [thread overview]
Message-ID: <20190628164741.GA27936@apalos> (raw)
In-Reply-To: <20190628153552.78a8c5ad@carbon>
On Fri, Jun 28, 2019 at 03:35:52PM +0200, Jesper Dangaard Brouer wrote:
> On Fri, 28 Jun 2019 13:39:15 +0300
> Ilias Apalodimas <ilias.apalodimas@linaro•org> wrote:
>
> > +static int netsec_xdp_setup(struct netsec_priv *priv, struct bpf_prog *prog,
> > + struct netlink_ext_ack *extack)
> > +{
> > + struct net_device *dev = priv->ndev;
> > + struct bpf_prog *old_prog;
> > +
> > + /* For now just support only the usual MTU sized frames */
> > + if (prog && dev->mtu > 1500) {
> > + NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not supported on XDP");
> > + return -EOPNOTSUPP;
> > + }
> > +
> > + if (netif_running(dev))
> > + netsec_netdev_stop(dev);
> > +
> > + /* Detach old prog, if any */
> > + old_prog = xchg(&priv->xdp_prog, prog);
> > + if (old_prog)
> > + bpf_prog_put(old_prog);
> > +
> > + if (netif_running(dev))
> > + netsec_netdev_open(dev);
>
> Shouldn't the if-statement be if (!netif_running(dev))
>
> > +
This is there to restart the device if it's up already (to rebuild the rings).
This should be fine as-is
> > + return 0;
> > +}
Thanks
/Ilias
next prev parent reply other threads:[~2019-06-28 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 10:39 [PATCH 0/3, net-next] net: netsec: Add XDP Support Ilias Apalodimas
2019-06-28 10:39 ` [PATCH 1/3, net-next] net: netsec: Use page_pool API Ilias Apalodimas
2019-06-28 13:03 ` Jesper Dangaard Brouer
2019-06-28 13:04 ` Jesper Dangaard Brouer
2019-06-28 16:43 ` David Miller
2019-06-28 17:19 ` Ilias Apalodimas
2019-06-28 17:41 ` Jesper Dangaard Brouer
2019-06-28 10:39 ` [PATCH 2/3, net-next] net: page_pool: add helper function for retrieving dma direction Ilias Apalodimas
2019-06-28 13:07 ` Jesper Dangaard Brouer
2019-06-28 10:39 ` [PATCH 3/3, net-next] net: netsec: add XDP support Ilias Apalodimas
2019-06-28 13:35 ` Jesper Dangaard Brouer
2019-06-28 16:44 ` David Miller
2019-06-28 16:47 ` Ilias Apalodimas [this message]
2019-06-28 17:23 ` Maciej Fijalkowski
2019-06-28 17:59 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628164741.GA27936@apalos \
--to=ilias.apalodimas@linaro$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bjorn.topel@intel$(echo .)com \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jaswinder.singh@linaro$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=maciejromanfijalkowski@gmail$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox