From: Greg KH <gregkh@linuxfoundation•org>
To: Jason Gunthorpe <jgg@mellanox•com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"dledford@redhat•com" <dledford@redhat•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"nhorman@redhat•com" <nhorman@redhat•com>,
"sassmann@redhat•com" <sassmann@redhat•com>,
"poswald@suse•com" <poswald@suse•com>,
"mustafa.ismail@intel•com" <mustafa.ismail@intel•com>,
"shiraz.saleem@intel•com" <shiraz.saleem@intel•com>,
Dave Ertman <david.m.ertman@intel•com>,
Andrew Bowers <andrewx.bowers@intel•com>
Subject: Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA
Date: Thu, 4 Jul 2019 14:29:50 +0200 [thread overview]
Message-ID: <20190704122950.GA6007@kroah.com> (raw)
In-Reply-To: <20190704121632.GB3401@mellanox.com>
On Thu, Jul 04, 2019 at 12:16:41PM +0000, Jason Gunthorpe wrote:
> On Wed, Jul 03, 2019 at 07:12:50PM -0700, Jeff Kirsher wrote:
> > From: Tony Nguyen <anthony.l.nguyen@intel•com>
> >
> > The RDMA block does not advertise on the PCI bus or any other bus.
> > Thus the ice driver needs to provide access to the RDMA hardware block
> > via a virtual bus; utilize the platform bus to provide this access.
> >
> > This patch initializes the driver to support RDMA as well as creates
> > and registers a platform device for the RDMA driver to register to. At
> > this point the driver is fully initialized to register a platform
> > driver, however, can not yet register as the ops have not been
> > implemented.
>
> I think you need Greg's ack on all this driver stuff - particularly
> that a platform_device is OK.
A platform_device is almost NEVER ok.
Don't abuse it, make a real device on a real bus. If you don't have a
real bus and just need to create a device to hang other things off of,
then use the virtual one, that's what it is there for.
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-04 12:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 2:12 [net-next 0/3][pull request] Intel Wired LAN ver Updates 2019-07-03 Jeff Kirsher
2019-07-04 2:12 ` [net-next 1/3] ice: Initialize and register platform device to provide RDMA Jeff Kirsher
2019-07-04 12:16 ` Jason Gunthorpe
2019-07-04 12:29 ` Greg KH [this message]
2019-07-04 12:37 ` Jason Gunthorpe
2019-07-04 12:42 ` Greg KH
2019-07-04 12:48 ` Jason Gunthorpe
2019-07-04 13:46 ` Greg KH
2019-07-04 13:53 ` Jason Gunthorpe
2019-07-05 16:33 ` Saleem, Shiraz
2019-07-06 8:25 ` Greg KH
2019-07-06 16:03 ` Saleem, Shiraz
2019-07-04 2:12 ` [net-next 2/3] ice: Implement peer communications Jeff Kirsher
2019-07-04 2:12 ` [net-next 3/3] i40e: Register RDMA client devices to the virtual platform bus Jeff Kirsher
2019-07-04 12:15 ` [net-next 0/3][pull request] Intel Wired LAN ver Updates 2019-07-03 Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704122950.GA6007@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=andrewx.bowers@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.m.ertman@intel$(echo .)com \
--cc=dledford@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jgg@mellanox$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=mustafa.ismail@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=poswald@suse$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
--cc=shiraz.saleem@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox