From: Leon Romanovsky <leon@kernel•org>
To: Jason Gunthorpe <jgg@ziepe•ca>
Cc: Doug Ledford <dledford@redhat•com>,
RDMA mailing list <linux-rdma@vger•kernel.org>,
Majd Dibbiny <majd@mellanox•com>, Mark Zhang <markz@mellanox•com>,
Saeed Mahameed <saeedm@mellanox•com>,
linux-netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH rdma-next v5 00/17] Statistics counter support
Date: Thu, 4 Jul 2019 21:39:09 +0300 [thread overview]
Message-ID: <20190704183909.GL7212@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190704182529.GA20631@ziepe.ca>
On Thu, Jul 04, 2019 at 03:25:29PM -0300, Jason Gunthorpe wrote:
> On Tue, Jul 02, 2019 at 01:02:29PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox•com>
> >
> > Changelog:
> > v4 -> v5:
> > * Patch #6 and #14 - consolidated many counter release functions,
> > removed mutex lock protection from dealloc_counter() call
> > and simplified kref_put/kref_get operations.
> > * Added Saeed's ACK tags.
> > v3 -> v4:
> > * Add counter_dealloc() callback function
> > * Moved to kref implementation
> > * Fixed lock during spinlock
> > v2 -> v3:
> > * We didn't change use of atomics over kref for management of unbind
> > counter from QP. The reason to it that bind and unbind are non-symmetric
> > in regards of put and get, so we need to count differently memory
> > release flows of HW objects (restrack) and SW bind operations.
> > * Everything else was addressed.
> > v1 -> v2:
> > * Rebased to latest rdma-next
> > v0 -> v1:
> > * Changed wording of counter comment
> > * Removed unneeded assignments
> > * Added extra patch to present global counters
> >
> >
> > Hi,
> >
> > This series from Mark provides dynamic statistics infrastructure.
> > He uses netlink interface to configure and retrieve those counters.
> >
> > This infrastructure allows to users monitor various objects by binding
> > to them counters. As the beginning, we used QP object as target for
> > those counters, but future patches will include ODP MR information too.
> >
> > Two binding modes are supported:
> > - Auto: This allows a user to build automatic set of objects to a counter
> > according to common criteria. For example in a per-type scheme, where in
> > one process all QPs with same QP type are bound automatically to a single
> > counter.
> > - Manual: This allows a user to manually bind objects on a counter.
> >
> > Those two modes are mutual-exclusive with separation between processes,
> > objects created by different processes cannot be bound to a same counter.
> >
> > For objects which don't support counter binding, we will return
> > pre-allocated counters.
> >
> > $ rdma statistic qp set link mlx5_2/1 auto type on
> > $ rdma statistic qp set link mlx5_2/1 auto off
> > $ rdma statistic qp bind link mlx5_2/1 lqpn 178
> > $ rdma statistic qp unbind link mlx5_2/1 cntn 4 lqpn 178
> > $ rdma statistic show
> > $ rdma statistic qp mode
> >
> > Thanks
> >
> >
> > Mark Zhang (17):
> > net/mlx5: Add rts2rts_qp_counters_set_id field in hca cap
> > RDMA/restrack: Introduce statistic counter
> > RDMA/restrack: Add an API to attach a task to a resource
> > RDMA/restrack: Make is_visible_in_pid_ns() as an API
> > RDMA/counter: Add set/clear per-port auto mode support
> > RDMA/counter: Add "auto" configuration mode support
> > IB/mlx5: Support set qp counter
> > IB/mlx5: Add counter set id as a parameter for
> > mlx5_ib_query_q_counters()
> > IB/mlx5: Support statistic q counter configuration
> > RDMA/nldev: Allow counter auto mode configration through RDMA netlink
> > RDMA/netlink: Implement counter dumpit calback
> > IB/mlx5: Add counter_alloc_stats() and counter_update_stats() support
> > RDMA/core: Get sum value of all counters when perform a sysfs stat
> > read
> > RDMA/counter: Allow manual mode configuration support
> > RDMA/nldev: Allow counter manual mode configration through RDMA
> > netlink
> > RDMA/nldev: Allow get counter mode through RDMA netlink
> > RDMA/nldev: Allow get default counter statistics through RDMA netlink
>
> Well, I can made the needed edits, can you apply the the first patch
> to the shared branch?
Thanks, pushed
f8efee08dd9d net/mlx5: Add rts2rts_qp_counters_set_id field in hca cap
>
> Thanks,
> Jason
next prev parent reply other threads:[~2019-07-04 18:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 10:02 [PATCH rdma-next v5 00/17] Statistics counter support Leon Romanovsky
2019-07-02 10:02 ` [PATCH mlx5-next v5 01/17] net/mlx5: Add rts2rts_qp_counters_set_id field in hca cap Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 02/17] RDMA/restrack: Introduce statistic counter Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 03/17] RDMA/restrack: Add an API to attach a task to a resource Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 04/17] RDMA/restrack: Make is_visible_in_pid_ns() as an API Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 05/17] RDMA/counter: Add set/clear per-port auto mode support Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 06/17] RDMA/counter: Add "auto" configuration " Leon Romanovsky
2019-07-04 18:09 ` Jason Gunthorpe
2019-07-02 10:02 ` [PATCH mlx5-next v5 07/17] IB/mlx5: Support set qp counter Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 08/17] IB/mlx5: Add counter set id as a parameter for mlx5_ib_query_q_counters() Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 09/17] IB/mlx5: Support statistic q counter configuration Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 10/17] RDMA/nldev: Allow counter auto mode configration through RDMA netlink Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 11/17] RDMA/netlink: Implement counter dumpit calback Leon Romanovsky
2019-07-04 18:07 ` Jason Gunthorpe
2019-07-04 18:22 ` Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 12/17] IB/mlx5: Add counter_alloc_stats() and counter_update_stats() support Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 13/17] RDMA/core: Get sum value of all counters when perform a sysfs stat read Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 14/17] RDMA/counter: Allow manual mode configuration support Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 15/17] RDMA/nldev: Allow counter manual mode configration through RDMA netlink Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 16/17] RDMA/nldev: Allow get counter mode " Leon Romanovsky
2019-07-02 10:02 ` [PATCH rdma-next v5 17/17] RDMA/nldev: Allow get default counter statistics " Leon Romanovsky
2019-07-04 18:25 ` [PATCH rdma-next v5 00/17] Statistics counter support Jason Gunthorpe
2019-07-04 18:39 ` Leon Romanovsky [this message]
2019-07-05 15:50 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704183909.GL7212@mtr-leonro.mtl.com \
--to=leon@kernel$(echo .)org \
--cc=dledford@redhat$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=majd@mellanox$(echo .)com \
--cc=markz@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox