From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: Antoine Tenart <antoine.tenart@bootlin•com>
Cc: davem@davemloft•net, richardcochran@gmail•com,
alexandre.belloni@bootlin•com, UNGLinuxDriver@microchip•com,
ralf@linux-mips•org, paul.burton@mips•com, jhogan@kernel•org,
netdev@vger•kernel.org, linux-mips@vger•kernel.org,
thomas.petazzoni@bootlin•com, allan.nielsen@microchip•com
Subject: Re: [PATCH net-next v2 8/8] net: mscc: PTP Hardware Clock (PHC) support
Date: Mon, 8 Jul 2019 12:06:26 -0700 [thread overview]
Message-ID: <20190708120626.2cecc86b@cakuba.netronome.com> (raw)
In-Reply-To: <20190708084809.GB2932@kwain>
On Mon, 8 Jul 2019 10:48:09 +0200, Antoine Tenart wrote:
> > > + /* Commit back the result & save it */
> > > + memcpy(&ocelot->hwtstamp_config, &cfg, sizeof(cfg));
> > > + mutex_unlock(&ocelot->ptp_lock);
> > > +
> > > + return copy_to_user(ifr->ifr_data, &cfg, sizeof(cfg)) ? -EFAULT : 0;
> > > +}
> > >
> > > +static int ocelot_get_ts_info(struct net_device *dev,
> > > + struct ethtool_ts_info *info)
> > > +{
> > > + struct ocelot_port *ocelot_port = netdev_priv(dev);
> > > + struct ocelot *ocelot = ocelot_port->ocelot;
> > > + int ret;
> > > +
> > > + if (!ocelot->ptp)
> > > + return -EOPNOTSUPP;
> >
> > Hmm.. why does software timestamping depend on PTP?
>
> Because it depends on the "PTP" register bank (and the "PTP" interrupt)
> being described and available. This is why I named the flag 'ptp', but
> it could be named 'timestamp' or 'ts' as well.
Right, but software timestamps are done by calling skb_tx_timestamp(skb)
in the driver, no need for HW support there (software RX timestamp is
handled by the stack).
next prev parent reply other threads:[~2019-07-08 19:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 19:52 [PATCH net-next v2 0/8] net: mscc: PTP Hardware Clock (PHC) support Antoine Tenart
2019-07-05 19:52 ` [PATCH net-next v2 1/8] Documentation/bindings: net: ocelot: document the PTP bank Antoine Tenart
2019-07-05 19:52 ` [PATCH net-next v2 2/8] MIPS: dts: mscc: describe the PTP register range Antoine Tenart
2019-07-22 22:24 ` Paul Burton
2019-07-05 19:52 ` [PATCH net-next v2 3/8] Documentation/bindings: net: ocelot: document the PTP ready IRQ Antoine Tenart
2019-07-05 19:52 ` [PATCH net-next v2 4/8] MIPS: dts: mscc: describe the PTP ready interrupt Antoine Tenart
2019-07-05 19:52 ` [PATCH net-next v2 5/8] net: mscc: describe the PTP register range Antoine Tenart
2019-07-05 19:52 ` [PATCH net-next v2 6/8] net: mscc: improve the frame header parsing readability Antoine Tenart
2019-07-05 19:52 ` [PATCH net-next v2 7/8] net: mscc: remove the frame_info cpuq member Antoine Tenart
2019-07-05 19:52 ` [PATCH net-next v2 8/8] net: mscc: PTP Hardware Clock (PHC) support Antoine Tenart
2019-07-05 22:02 ` Richard Cochran
2019-07-08 8:17 ` Antoine Tenart
2019-07-05 22:10 ` Jakub Kicinski
2019-07-08 8:48 ` Antoine Tenart
2019-07-08 19:06 ` Jakub Kicinski [this message]
2019-07-09 15:23 ` Antoine Tenart
2019-07-20 15:23 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708120626.2cecc86b@cakuba.netronome.com \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=allan.nielsen@microchip$(echo .)com \
--cc=antoine.tenart@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhogan@kernel$(echo .)org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.burton@mips$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=richardcochran@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox