From: Andrew Lunn <andrew@lunn•ch>
To: Niklas Cassel <niklas.cassel@linaro•org>
Cc: xiaofeis <xiaofeis@codeaurora•org>,
davem@davemloft•net, vkoul@kernel•org, netdev@vger•kernel.org,
linux-arm-msm@vger•kernel.org, bjorn.andersson@linaro•org,
vivien.didelot@gmail•com, f.fainelli@gmail•com,
xiazha@codeaurora•org
Subject: Re: [PATCH] qca8k: enable port flow control
Date: Fri, 19 Jul 2019 15:14:35 +0200 [thread overview]
Message-ID: <20190719131435.GB24930@lunn.ch> (raw)
In-Reply-To: <20190719093135.GA22605@centauri>
> Question for DSA maintainers: shouldn't this be implemented in the
> dsa_switch_ops phylink_validate callback, like it's done for other
> dsa drivers?
Hi Niklas
qca8K is still using phylib, not phylink. So the validate callback
cannot be used.
Andrew
next prev parent reply other threads:[~2019-07-19 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 2:53 [PATCH] qca8k: enable port flow control xiaofeis
2019-07-19 4:18 ` Vinod Koul
2019-07-19 9:31 ` Niklas Cassel
2019-07-19 13:14 ` Andrew Lunn [this message]
2019-07-19 13:13 ` Andrew Lunn
2019-07-24 5:09 ` xiaofeis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719131435.GB24930@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=niklas.cassel@linaro$(echo .)org \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vkoul@kernel$(echo .)org \
--cc=xiaofeis@codeaurora$(echo .)org \
--cc=xiazha@codeaurora$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox