From: Kalle Valo <kvalo@codeaurora•org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: Stanislaw Gruszka <sgruszka@redhat•com>,
Helmut Schaa <helmut.schaa@googlemail•com>,
"David S. Miller" <davem@davemloft•net>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH v2] rt2x00: no need to check return value of debugfs_create functions
Date: Wed, 24 Jul 2019 11:43:26 +0000 (UTC) [thread overview]
Message-ID: <20190724114326.ED3A36043F@smtp.codeaurora.org> (raw)
In-Reply-To: <20190703113956.GA26652@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation•org> wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Because we don't need to save the individual debugfs files and
> directories, remove the local storage of them and just remove the entire
> debugfs directory in a single call, making things a lot simpler.
>
> Cc: Stanislaw Gruszka <sgruszka@redhat•com>
> Cc: Helmut Schaa <helmut.schaa@googlemail•com>
> Cc: Kalle Valo <kvalo@codeaurora•org>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: linux-wireless@vger•kernel.org
> Cc: netdev@vger•kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat•com>
Patch applied to wireless-drivers-next.git, thanks.
1dc244064c47 rt2x00: no need to check return value of debugfs_create functions
--
https://patchwork.kernel.org/patch/11029367/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-07-24 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 6:56 [PATCH] rt2x00: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-07-03 10:58 ` Stanislaw Gruszka
2019-07-03 11:08 ` Greg Kroah-Hartman
2019-07-03 11:39 ` [PATCH v2] " Greg Kroah-Hartman
2019-07-04 7:50 ` Stanislaw Gruszka
2019-07-24 11:43 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724114326.ED3A36043F@smtp.codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=helmut.schaa@googlemail$(echo .)com \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sgruszka@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox