Subject: Re: [PATCH] net: geneve: Fix a possible null-pointer dereference in geneve_link_config()

From: Jiri Benc <[email-masked]>
Date: Mon, 29 Jul 2019 12:30:55 +0200

On Mon, 29 Jul 2019 18:26:11 +0800, Jia-Ju Bai wrote:
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -1521,9 +1521,10 @@ static void geneve_link_config(struct net_device *dev,
>  		rt = rt6_lookup(geneve->net, &info->key.u.ipv6.dst, NULL, 0,
>  				NULL, 0);
>  
> -		if (rt && rt->dst.dev)
> +		if (rt && rt->dst.dev) {
>  			ldev_mtu = rt->dst.dev->mtu - GENEVE_IPV6_HLEN;
> -		ip6_rt_put(rt);
> +			ip6_rt_put(rt);
> +		}
>  		break;
>  	}
>  #endif

Are you sure rt6_lookup can never return a non-NULL rt with rt->dst.dev
being NULL? You'd leak the reference in such case.

 Jiri