Subject: Re: [PATCH] net: geneve: Fix a possible null-pointer dereference in geneve_link_config()

From: Jiri Benc <[email-masked]>
Date: Mon, 29 Jul 2019 12:52:21 +0200

On Mon, 29 Jul 2019 12:30:55 +0200, Jiri Benc wrote:
> Are you sure rt6_lookup can never return a non-NULL rt with rt->dst.dev
> being NULL? You'd leak the reference in such case.

In fact, you're introducing a bug, not fixing one. ip6_rt_put does
accept NULL parameter. And it seems you already have been told that?

Nacked-by: Jiri Benc <[email-masked]>

 Jiri