Subject: Re: [PATCH net-next v3 1/4] enetc: Clean up local mdio bus allocation

From: Andrew Lunn <[email-masked]>
Date: Mon, 29 Jul 2019 17:32:02 +0200

On Mon, Jul 29, 2019 at 01:03:44PM +0300, Claudiu Manoil wrote:
> What's needed is basically a pointer to the mdio registers.
> This is one way to store it inside bus->priv allocated space,
> without upsetting sparse.
> Reworked accessors to avoid __iomem casting.
> Used devm_* variant to further clean up the init error /
> remove paths.
> 
> Fixes following sparse warning:
>  warning: incorrect type in assignment (different address spaces)
>     expected void *priv
>     got struct enetc_mdio_regs [noderef] <asn:2>*[assigned] regs
> 
> Fixes: ebfcb23d62ab ("enetc: Add ENETC PF level external MDIO support")
> 
> Signed-off-by: Claudiu Manoil <[email-masked]>

Thanks, much nicer.

Reviewed-by: Andrew Lunn <[email-masked]>

    Andrew