From: Andrew Lunn <andrew@lunn•ch>
To: Tao Ren <taoren@fb•com>
Cc: Vladimir Oltean <olteanv@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Arun Parameswaran <arun.parameswaran@broadcom•com>,
Justin Chen <justinpopo6@gmail•com>,
netdev <netdev@vger•kernel.org>,
lkml <linux-kernel@vger•kernel.org>,
Andrew Jeffery <andrew@aj•id.au>,
"openbmc@lists•ozlabs.org" <openbmc@lists•ozlabs.org>
Subject: Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S
Date: Wed, 31 Jul 2019 03:36:36 +0200 [thread overview]
Message-ID: <20190731013636.GC25700@lunn.ch> (raw)
In-Reply-To: <e8f85ef3-1216-8efb-a54d-84426234fe82@fb.com>
> The INTF_SEL pins report correct mode (RGMII-Fiber) on my machine,
> but there are 2 "sub-modes" (1000Base-X and 100Base-FX) and I
> couldn't find a proper/safe way to auto-detect which "sub-mode" is
> active. The datasheet just describes instructions to enable a
> specific mode, but it doesn't say 1000Base-X/100Base-FX mode will be
> auto-selected. And that's why I came up with the patch to specify
> 1000Base-X mode.
Fibre does not perform any sort of auto-negotiation. I assume you have
an SFP connected? When using PHYLINK, the sfp driver will get the
supported baud rate from SFP EEPROM to determine what speed could be
used. However, there is currently no mainline support for having a
chain MAC-PHY-SFP. For that you need Russells out of tree patches.
Andrew
next prev parent reply other threads:[~2019-07-31 1:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190730002549.86824-1-taoren@fb.com>
2019-07-30 1:32 ` [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S Vladimir Oltean
2019-07-30 4:52 ` Tao Ren
2019-07-30 10:15 ` Vladimir Oltean
2019-07-30 13:17 ` Andrew Lunn
2019-07-31 0:15 ` Tao Ren
2019-07-30 23:44 ` Tao Ren
2019-07-31 1:36 ` Andrew Lunn [this message]
2019-07-31 2:09 ` Tao Ren
2019-07-31 2:34 ` Andrew Lunn
2019-07-31 5:55 ` Tao Ren
2019-08-01 5:07 ` Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731013636.GC25700@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=andrew@aj$(echo .)id.au \
--cc=arun.parameswaran@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=justinpopo6@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=openbmc@lists$(echo .)ozlabs.org \
--cc=taoren@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox