Subject: Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card

From: Johan Hovold <[email-masked]>
Date: Mon, 5 Aug 2019 13:47:11 +0200

On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote:
> From: Bob Ham <[email-masked]>
> 
> Add a VID:PID for the BroadModi BM818 M.2 card

Would you mind posting the output of usb-devices (or lsusb -v) for this
device?

> Signed-off-by: Bob Ham <[email-masked]>
> Signed-off-by: Angus Ainslie (Purism) <[email-masked]>
> ---
>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index c1582fbd1150..674a68ee9564 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1975,6 +1975,8 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = RSVD(4) | RSVD(5) },
>  	{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0105, 0xff),			/* Fibocom NL678 series */
>  	  .driver_info = RSVD(6) },
> +	{ USB_DEVICE(0x2020, 0x2060),						/* BroadMobi  */

Looks like you forgot to include the model in the comment here.

And please move this one after the other 0x2020 (PID 0x2031) entry.

Should you also be using USB_DEVICE_INTERFACE_CLASS() (e.g. to avoid
matching a mass-storage interface)?

> +	  .driver_info = RSVD(4) },
>  	{ } /* Terminating entry */
>  };
>  MODULE_DEVICE_TABLE(usb, option_ids);

Johan