From: Jesse Brandeburg <jesse.brandeburg@intel•com>
To: Christophe JAILLET <christophe.jaillet@wanadoo•fr>
Cc: <mark.einon@gmail•com>, <davem@davemloft•net>,
<willy@infradead•org>, <f.fainelli@gmail•com>, <andrew@lunn•ch>,
<netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<kernel-janitors@vger•kernel.org>,
jesse.brandeburg@intel•com
Subject: Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring
Date: Wed, 7 Aug 2019 22:23:46 -0700 [thread overview]
Message-ID: <20190807222346.00002ba7@intel.com> (raw)
In-Reply-To: <20190731073842.16948-1-christophe.jaillet@wanadoo.fr>
On Wed, 31 Jul 2019 09:38:42 +0200
Christophe JAILLET <christophe.jaillet@wanadoo•fr> wrote:
> There is no good reason to use GFP_ATOMIC here. Other memory allocations
> are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and
> 'kzalloc()' in 'et131x_rx_dma_memory_alloc()')
>
> Use GFP_KERNEL which should be enough.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo•fr>
Sure, but generally I'd say GFP_ATOMIC is ok if you're in an init path
and you can afford to have the allocation thread sleep while memory is
being found by the kernel.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel•com>
next prev parent reply other threads:[~2019-08-08 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 7:38 [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring Christophe JAILLET
2019-07-31 15:36 ` David Miller
2019-08-08 5:23 ` Jesse Brandeburg [this message]
2019-08-08 11:24 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807222346.00002ba7@intel.com \
--to=jesse.brandeburg@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.einon@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=willy@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox