From: Jiri Pirko <jiri@resnulli•us>
To: Jakub Kicinski <jakub.kicinski@netronome•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, mlxsw@mellanox•com
Subject: Re: [patch net-next v2 2/2] selftests: netdevsim: add devlink params tests
Date: Thu, 15 Aug 2019 10:52:14 +0200 [thread overview]
Message-ID: <20190815085214.GC2273@nanopsycho> (raw)
In-Reply-To: <20190815084545.GB2273@nanopsycho>
Thu, Aug 15, 2019 at 10:45:45AM CEST, jiri@resnulli•us wrote:
>Thu, Aug 15, 2019 at 03:09:00AM CEST, jakub.kicinski@netronome•com wrote:
>>On Wed, 14 Aug 2019 17:26:04 +0200, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox•com>
>>>
>>> Test recently added netdevsim devlink param implementation.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
>>> ---
>>> v1->v2:
>>> -using cmd_jq helper
>>
>>Still failing here :(
>>
>># ./devlink.sh
>>TEST: fw flash test [ OK ]
>>TEST: params test [FAIL]
>> Failed to get test1 param value
>>TEST: regions test [ OK ]
>>
>># jq --version
>>jq-1.5-1-a5b5cbe
>># echo '{ "a" : false }' | jq -e -r '.[]'
>>false
>># echo $?
>>1
>
>Odd, could you please try:
>$ jq --version
>jq-1.5
>$ echo '{"param":{"netdevsim/netdevsim11":[{"name":"test1","type":"driver-specific","values":[{"cmode":"driverinit","value":"false"}]}]}}' | jq -e -r '.[][][].values[] | select(.cmode == "driverinit").value'
>false
>$ echo $?
>0
Ah, it is not the jq version, it is the iproute2 version:
8257e6c49cca9847e01262f6e749c6e88e2ddb72
I'll think about how to fix this.
>
>
>>
>>On another machine:
>>
>>$ echo '{ "a" : false }' | jq -e -r '.[]'
>>false
>>$ echo $?
>>1
>>
>>Did you mean to drop the -e ?
next prev parent reply other threads:[~2019-08-15 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 15:26 [patch net-next v2 0/2] selftests: netdevsim: add devlink paramstests Jiri Pirko
2019-08-14 15:26 ` [patch net-next v2 1/2] selftests: net: push jq workaround into separate helper Jiri Pirko
2019-08-14 15:26 ` [patch net-next v2 2/2] selftests: netdevsim: add devlink params tests Jiri Pirko
2019-08-15 1:09 ` Jakub Kicinski
2019-08-15 5:58 ` Jiri Pirko
2019-08-15 8:45 ` Jiri Pirko
2019-08-15 8:52 ` Jiri Pirko [this message]
2019-08-15 17:12 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815085214.GC2273@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=davem@davemloft$(echo .)net \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox