From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: YueHaibing <yuehaibing@huawei•com>
Cc: <davem@davemloft•net>, <idosch@mellanox•com>, <jiri@mellanox•com>,
<mcroce@redhat•com>, <linux-kernel@vger•kernel.org>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH v2 net-next] netdevsim: Fix build error without CONFIG_INET
Date: Tue, 20 Aug 2019 10:48:39 -0700 [thread overview]
Message-ID: <20190820104839.511367fa@cakuba.netronome.com> (raw)
In-Reply-To: <20190820141446.71604-1-yuehaibing@huawei.com>
On Tue, 20 Aug 2019 22:14:46 +0800, YueHaibing wrote:
> If CONFIG_INET is not set, building fails:
>
> drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work':
> dev.c:(.text+0x67b): undefined reference to `ip_send_check'
>
> Use ip_fast_csum instead of ip_send_check to avoid
> dependencies on CONFIG_INET.
>
> Reported-by: Hulk Robot <hulkci@huawei•com>
> Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support")
> Signed-off-by: YueHaibing <yuehaibing@huawei•com>
Thank you!
Acked-by: Jakub Kicinski <jakub.kicinski@netronome•com>
next prev parent reply other threads:[~2019-08-20 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 12:08 [PATCH net-next] netdevsim: Fix build error without CONFIG_INET YueHaibing
2019-08-19 15:58 ` Ido Schimmel
2019-08-19 21:59 ` Jakub Kicinski
2019-08-20 14:08 ` Ido Schimmel
2019-08-20 14:14 ` [PATCH v2 " YueHaibing
2019-08-20 17:48 ` Jakub Kicinski [this message]
2019-08-20 18:10 ` Ido Schimmel
2019-08-20 20:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820104839.511367fa@cakuba.netronome.com \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mcroce@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox