Subject: Re: [PATCH net-next 03/10] net: dsa: mv88e6xxx: move hidden registers operations in own file

From: Andrew Lunn <[email-masked]>
Date: Thu, 22 Aug 2019 15:10:47 +0200

On Thu, Aug 22, 2019 at 01:27:17AM +0200, Marek Behún wrote:
> This patch moves the functions operating on the hidden debug registers
> into it's own file, hidden.c.

Humm, actually...

These are in the port register space. Maybe it would be better to move
them into port.c/port.h?

What you really need is that they have global scope within the driver
so you can call them. So add the functions definitions to port.h.

Vivien, what do you think?

	Andrew