Subject: Re: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts

From: Andrew Lunn <[email-masked]>
Date: Wed, 4 Sep 2019 16:58:04 +0200

On Wed, Sep 04, 2019 at 10:02:54PM +0800, Voon Weifeng wrote:
> From: "Chuah, Kim Tatt" <[email-masked]>
> 
> DW EQoS v5.xx controllers added capability for interrupt generation
> when MDIO interface is done (GMII Busy bit is cleared).
> This patch adds support for this interrupt on supported HW to avoid
> polling on GMII Busy bit.
> 
> stmmac_mdio_read() & stmmac_mdio_write() will sleep until wake_up() is
> called by the interrupt handler.
> 
> Reviewed-by: Voon Weifeng <[email-masked]>
> Reviewed-by: Kweh, Hock Leong <[email-masked]>
> Reviewed-by: Ong Boon Leong <[email-masked]>
> Signed-off-by: Chuah, Kim Tatt <[email-masked]>
> Signed-off-by: Ong Boon Leong <[email-masked]>
> Signed-off-by: Voon Weifeng <[email-masked]>

Hi Voon

It is normal to include a short description of what you changed
between the previous version and this version.

The formatting of this patch also looks a bit odd. Did you use 
git format-patch ; git send-email?

Thanks
	Andrew