From: Johan Hovold <johan@kernel•org>
To: Stefan Schmidt <stefan@datenfreihafen•org>
Cc: Alexander Aring <alex.aring@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
linux-wpan@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, andreyknvl@google•com,
syzkaller-bugs@googlegroups•com, Johan Hovold <johan@kernel•org>,
stable <stable@vger•kernel.org>,
syzbot+f4509a9138a1472e7e80@syzkaller•appspotmail.com
Subject: [PATCH] ieee802154: atusb: fix use-after-free at disconnect
Date: Thu, 19 Sep 2019 14:12:34 +0200 [thread overview]
Message-ID: <20190919121234.30620-1-johan@kernel.org> (raw)
The disconnect callback was accessing the hardware-descriptor private
data after having having freed it.
Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver")
Cc: stable <stable@vger•kernel.org> # 4.2
Cc: Alexander Aring <alex.aring@gmail•com>
Reported-by: syzbot+f4509a9138a1472e7e80@syzkaller•appspotmail.com
Signed-off-by: Johan Hovold <johan@kernel•org>
---
#syz test: https://github.com/google/kasan.git f0df5c1b
drivers/net/ieee802154/atusb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index ceddb424f887..0dd0ba915ab9 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -1137,10 +1137,11 @@ static void atusb_disconnect(struct usb_interface *interface)
ieee802154_unregister_hw(atusb->hw);
+ usb_put_dev(atusb->usb_dev);
+
ieee802154_free_hw(atusb->hw);
usb_set_intfdata(interface, NULL);
- usb_put_dev(atusb->usb_dev);
pr_debug("%s done\n", __func__);
}
--
2.23.0
next reply other threads:[~2019-09-19 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 12:12 Johan Hovold [this message]
2019-09-19 12:32 ` KASAN: use-after-free Read in atusb_disconnect syzbot
2019-09-19 14:56 ` [PATCH] ieee802154: atusb: fix use-after-free at disconnect Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919121234.30620-1-johan@kernel.org \
--to=johan@kernel$(echo .)org \
--cc=alex.aring@gmail$(echo .)com \
--cc=andreyknvl@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wpan@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=stefan@datenfreihafen$(echo .)org \
--cc=syzbot+f4509a9138a1472e7e80@syzkaller$(echo .)appspotmail.com \
--cc=syzkaller-bugs@googlegroups$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox