Subject: Re: [PATCH v2 2/3] seccomp: avoid overflow in implicit constant conversion

From: Tycho Andersen <[email-masked]>
Date: Fri, 20 Sep 2019 10:47:53 +0200

On Fri, Sep 20, 2019 at 10:30:06AM +0200, Christian Brauner wrote:
> USER_NOTIF_MAGIC is assigned to int variables in this test so set it to INT_MAX
> to avoid warnings:
> 
> seccomp_bpf.c: In function ‘user_notification_continue’:
> seccomp_bpf.c:3088:26: warning: overflow in implicit constant conversion [-Woverflow]
>  #define USER_NOTIF_MAGIC 116983961184613L
>                           ^
> seccomp_bpf.c:3572:15: note: in expansion of macro ‘USER_NOTIF_MAGIC’
>   resp.error = USER_NOTIF_MAGIC;
>                ^~~~~~~~~~~~~~~~
> 
> Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
> Signed-off-by: Christian Brauner <[email-masked]>
> Reviewed-by: Tyler Hicks <[email-masked]>
> Cc: Kees Cook <[email-masked]>
> Cc: Andy Lutomirski <[email-masked]>
> Cc: Will Drewry <[email-masked]>
> Cc: Shuah Khan <[email-masked]>
> Cc: Alexei Starovoitov <[email-masked]>
> Cc: Daniel Borkmann <[email-masked]>
> Cc: Martin KaFai Lau <[email-masked]>
> Cc: Song Liu <[email-masked]>
> Cc: Yonghong Song <[email-masked]>
> Cc: Tycho Andersen <[email-masked]>

You can also add,

Reviewed-by: Tycho Andersen <[email-masked]>

for this one.

Tycho