From: Jason Wang <jasowang@redhat•com>
To: kvm@vger•kernel.org, linux-s390@vger•kernel.org,
linux-kernel@vger•kernel.org, dri-devel@lists•freedesktop.org,
intel-gfx@lists•freedesktop.org,
intel-gvt-dev@lists•freedesktop.org, kwankhede@nvidia•com,
alex.williamson@redhat•com, mst@redhat•com, tiwei.bie@intel•com
Cc: virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, cohuck@redhat•com,
maxime.coquelin@redhat•com, cunming.liang@intel•com,
zhihong.wang@intel•com, rob.miller@broadcom•com,
xiao.w.wang@intel•com, haotian.wang@sifive•com,
zhenyuw@linux•intel.com, zhi.a.wang@intel•com,
jani.nikula@linux•intel.com, joonas.lahtinen@linux•intel.com,
rodrigo.vivi@intel•com, airlied@linux•ie, daniel@ffwll•ch,
farman@linux•ibm.com, pasic@linux•ibm.com, sebott@linux•ibm.com,
oberpar@linux•ibm.com, heiko.carstens@de•ibm.com,
gor@linux•ibm.com, borntraeger@de•ibm.com,
akrowiak@linux•ibm.com, freude@linux•ibm.com,
lingshan.zhu@intel•com, idos@mellanox•com, eperezma@redhat•com,
lulu@redhat•com, parav@mellanox•com,
Jason Wang <jasowang@redhat•com>
Subject: [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern()
Date: Mon, 23 Sep 2019 21:03:30 +0800 [thread overview]
Message-ID: <20190923130331.29324-6-jasowang@redhat.com> (raw)
In-Reply-To: <20190923130331.29324-1-jasowang@redhat.com>
We want to copy from iov to buf, so the direction was wrong.
Signed-off-by: Jason Wang <jasowang@redhat•com>
---
drivers/vhost/vringh.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
index 08ad0d1f0476..a0a2d74967ef 100644
--- a/drivers/vhost/vringh.c
+++ b/drivers/vhost/vringh.c
@@ -852,6 +852,12 @@ static inline int xfer_kern(void *src, void *dst, size_t len)
return 0;
}
+static inline int kern_xfer(void *dst, void *src, size_t len)
+{
+ memcpy(dst, src, len);
+ return 0;
+}
+
/**
* vringh_init_kern - initialize a vringh for a kernelspace vring.
* @vrh: the vringh to initialize.
@@ -958,7 +964,7 @@ EXPORT_SYMBOL(vringh_iov_pull_kern);
ssize_t vringh_iov_push_kern(struct vringh_kiov *wiov,
const void *src, size_t len)
{
- return vringh_iov_xfer(wiov, (void *)src, len, xfer_kern);
+ return vringh_iov_xfer(wiov, (void *)src, len, kern_xfer);
}
EXPORT_SYMBOL(vringh_iov_push_kern);
--
2.19.1
next prev parent reply other threads:[~2019-09-23 13:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 13:03 [PATCH 0/6] mdev based hardware virtio offloading support Jason Wang
2019-09-23 13:03 ` [PATCH 1/6] mdev: class id support Jason Wang
2019-09-23 16:05 ` Alex Williamson
2019-09-24 10:11 ` Jason Wang
2019-09-23 20:58 ` Parav Pandit
2019-09-24 11:20 ` Jason Wang
2019-09-23 21:02 ` Parav Pandit
2019-09-24 11:23 ` Jason Wang
2019-09-23 13:03 ` [PATCH 2/6] mdev: introduce device specific ops Jason Wang
2019-09-23 15:20 ` kbuild test robot
2019-09-23 15:36 ` Michael S. Tsirkin
2019-09-24 11:23 ` Jason Wang
2019-09-23 22:59 ` Parav Pandit
2019-09-24 11:26 ` Jason Wang
2019-09-23 13:03 ` [PATCH 3/6] mdev: introduce virtio device and its device ops Jason Wang
2019-09-23 13:03 ` [PATCH 4/6] virtio: introduce a mdev based transport Jason Wang
2019-09-23 22:28 ` Parav Pandit
2019-09-24 11:30 ` Jason Wang
2019-09-23 13:03 ` Jason Wang [this message]
2019-09-23 15:45 ` [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern() Alex Williamson
2019-09-23 16:00 ` Michael S. Tsirkin
2019-09-24 14:04 ` Alex Williamson
2019-09-25 11:56 ` Jason Wang
2019-09-23 13:03 ` [PATCH 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-09-23 13:59 ` [PATCH 0/6] mdev based hardware virtio offloading support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923130331.29324-6-jasowang@redhat.com \
--to=jasowang@redhat$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=akrowiak@linux$(echo .)ibm.com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=cohuck@redhat$(echo .)com \
--cc=cunming.liang@intel$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=eperezma@redhat$(echo .)com \
--cc=farman@linux$(echo .)ibm.com \
--cc=freude@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=haotian.wang@sifive$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=idos@mellanox$(echo .)com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=intel-gvt-dev@lists$(echo .)freedesktop.org \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kwankhede@nvidia$(echo .)com \
--cc=lingshan.zhu@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=lulu@redhat$(echo .)com \
--cc=maxime.coquelin@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oberpar@linux$(echo .)ibm.com \
--cc=parav@mellanox$(echo .)com \
--cc=pasic@linux$(echo .)ibm.com \
--cc=rob.miller@broadcom$(echo .)com \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=sebott@linux$(echo .)ibm.com \
--cc=tiwei.bie@intel$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xiao.w.wang@intel$(echo .)com \
--cc=zhenyuw@linux$(echo .)intel.com \
--cc=zhi.a.wang@intel$(echo .)com \
--cc=zhihong.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox