Subject: Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers

From: Greg Kroah-Hartman <[email-masked]>
Date: Tue, 1 Oct 2019 11:38:49 +0200

On Tue, Oct 01, 2019 at 11:07:39AM +0300, Jani Nikula wrote:
> The kernel has plenty of ternary operators to choose between constant
> strings, such as condition ? "yes" : "no", as well as value == 1 ? "" :
> "s":
> 
> $ git grep '? "yes" : "no"' | wc -l
> 258
> $ git grep '? "on" : "off"' | wc -l
> 204
> $ git grep '? "enabled" : "disabled"' | wc -l
> 196
> $ git grep '? "" : "s"' | wc -l
> 25
> 
> Additionally, there are some occurences of the same in reverse order,
> split to multiple lines, or otherwise not caught by the simple grep.
> 
> Add helpers to return the constant strings. Remove existing equivalent
> and conflicting functions in i915, cxgb4, and USB core. Further
> conversion can be done incrementally.
> 
> While the main goal here is to abstract recurring patterns, and slightly
> clean up the code base by not open coding the ternary operators, there
> are also some space savings to be had via better string constant
> pooling.
> 
> Cc: Joonas Lahtinen <[email-masked]>
> Cc: Rodrigo Vivi <[email-masked]>
> Cc: [email-masked]
> Cc: Vishal Kulkarni <[email-masked]>
> Cc: [email-masked]
> Cc: Greg Kroah-Hartman <[email-masked]>
> Cc: [email-masked]
> Cc: Andrew Morton <[email-masked]>
> Cc: [email-masked]
> Cc: Julia Lawall <[email-masked]>
> Cc: Rasmus Villemoes <[email-masked]>
> Reviewed-by: Greg Kroah-Hartman <[email-masked]> # v1

As this is a totally different version, please drop my reviewed-by as
that's really not true here :(