From: Florian Westphal <fw@strlen•de>
To: "Maciej Żenczykowski" <zenczykowski@gmail•com>
Cc: "Maciej Żenczykowski" <maze@google•com>,
"David S . Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, "Cong Wang" <xiyou.wangcong@gmail•com>,
"Eric Dumazet" <edumazet@google•com>,
"Pablo Neira Ayuso" <pablo@netfilter•org>
Subject: Re: [PATCH 2/2] netfilter: revert "conntrack: silent a memory leak warning"
Date: Tue, 8 Oct 2019 08:04:14 +0200 [thread overview]
Message-ID: <20191008060414.GB25052@breakpoint.cc> (raw)
In-Reply-To: <20191008053507.252202-2-zenczykowski@gmail.com>
Maciej Żenczykowski <zenczykowski@gmail•com> wrote:
> From: Maciej Żenczykowski <maze@google•com>
>
> This reverts commit 114aa35d06d4920c537b72f9fa935de5dd205260.
>
> By my understanding of kmemleak the reasoning for this patch
> is incorrect. If kmemleak couldn't handle rcu we'd have it
> reporting leaks all over the place. My belief is that this
> was instead papering over a real leak.
Perhaps, but note that this is related to nfct->ext, not nfct itself.
I think we could remove __krealloc and use krealloc directly with
a bit of changes in the nf_conntrack core to make sure we do not
access nfct->ext without holding a reference to nfct, and then drop
rcu protection of nfct->ext, I don't think its strictly required anymore.
next prev parent reply other threads:[~2019-10-08 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 5:35 [PATCH 1/2] netfilter: fix a memory leak in nf_conntrack_in Maciej Żenczykowski
2019-10-08 5:35 ` [PATCH 2/2] netfilter: revert "conntrack: silent a memory leak warning" Maciej Żenczykowski
2019-10-08 5:38 ` Maciej Żenczykowski
2019-10-08 5:58 ` Cong Wang
2019-10-08 6:04 ` Florian Westphal [this message]
2019-10-08 6:45 ` Maciej Żenczykowski
2019-10-08 7:10 ` Maciej Żenczykowski
2019-10-10 18:36 ` Cong Wang
2019-10-17 18:30 ` Maciej Żenczykowski
2019-10-08 6:01 ` [PATCH 1/2] netfilter: fix a memory leak in nf_conntrack_in Florian Westphal
2019-10-08 6:05 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008060414.GB25052@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=maze@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=zenczykowski@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox