Subject: Re: [net-next v3 7/7] renesas: reject unsupported external timestamp flags

From: Richard Cochran <[email-masked]>
Date: Sat, 12 Oct 2019 11:38:38 -0700

On Thu, Sep 26, 2019 at 11:11:09AM -0700, Jacob Keller wrote:
> Fix the renesas PTP support to explicitly reject any future flags that
> get added to the external timestamp request ioctl.
> 
> In order to maintain currently functioning code, this patch accepts all
> three current flags. This is because the PTP_RISING_EDGE and
> PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
> have interpreted them slightly differently.

This driver doesn't check the flags. Not knowing this HW, I can't say
which edges are time stamped.
 
> Cc: Sergei Shtylyov <[email-masked]>
> Signed-off-by: Jacob Keller <[email-masked]>

Reviewed-by: Richard Cochran <[email-masked]>