From: Andrew Lunn <andrew@lunn•ch>
To: Marek Vasut <marex@denx•de>
Cc: netdev@vger•kernel.org, "David S . Miller" <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>,
George McCollister <george.mccollister@gmail•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Sean Nyekjaer <sean.nyekjaer@prevas•dk>,
Tristram Ha <Tristram.Ha@microchip•com>,
Woojung Huh <woojung.huh@microchip•com>
Subject: Re: [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs
Date: Mon, 14 Oct 2019 16:07:19 +0200 [thread overview]
Message-ID: <20191014140719.GB21165@lunn.ch> (raw)
In-Reply-To: <20191013212404.31708-1-marex@denx.de>
On Sun, Oct 13, 2019 at 11:24:03PM +0200, Marek Vasut wrote:
> The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the
> same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs
> in the micrel PHY driver, it is used even with the KSZ87xx switch. This
> is wrong, since the KSZ8051 configures registers of the PHY which are
> not present on the simplified KSZ87xx switch PHYs and misconfigures
> other registers of the KSZ87xx switch PHYs.
>
> Fortunatelly, it is possible to tell apart the KSZ8051 PHY from the
> KSZ87xx switch by checking the Basic Status register Bit 0, which is
> read-only and indicates presence of the Extended Capability Registers.
> The KSZ8051 PHY has those registers while the KSZ87xx switch does not.
>
> This patch implements simple check for the presence of this bit for
> both the KSZ8051 PHY and KSZ87xx switch, to let both use the correct
> PHY driver instance.
>
> Signed-off-by: Marek Vasut <marex@denx•de>
> Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795")
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2019-10-14 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 21:24 [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs Marek Vasut
2019-10-13 21:24 ` [PATCH net V4 2/2] net: phy: micrel: Update KSZ87xx PHY name Marek Vasut
2019-10-14 14:08 ` Andrew Lunn
2019-10-14 14:07 ` Andrew Lunn [this message]
2019-10-16 0:42 ` [PATCH net V4 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs David Miller
2019-10-16 13:39 ` Marek Vasut
2019-10-16 17:46 ` David Miller
2019-10-16 18:06 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014140719.GB21165@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Tristram.Ha@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=george.mccollister@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=marex@denx$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sean.nyekjaer@prevas$(echo .)dk \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox