From: Andrew Lunn <andrew@lunn•ch>
To: Jakub Kicinski <jakub.kicinski@netronome•com>
Cc: Ioana Ciornei <ioana.ciornei@nxp•com>,
davem@davemloft•net, netdev@vger•kernel.org,
Ioana Radulescu <ruxandra.radulescu@nxp•com>
Subject: Re: [PATCH v2 net 2/2] dpaa2-eth: Fix TX FQID values
Date: Tue, 15 Oct 2019 21:47:04 +0200 [thread overview]
Message-ID: <20191015194704.GE7839@lunn.ch> (raw)
In-Reply-To: <20191015124017.64a3d19b@cakuba.netronome.com>
On Tue, Oct 15, 2019 at 12:40:17PM -0700, Jakub Kicinski wrote:
> On Tue, 15 Oct 2019 21:29:23 +0200, Andrew Lunn wrote:
> > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> > > index 5acd734a216b..c3c2c06195ae 100644
> > > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> > > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> > > @@ -1235,6 +1235,8 @@ static void dpaa2_eth_set_rx_taildrop(struct dpaa2_eth_priv *priv, bool enable)
> > > priv->rx_td_enabled = enable;
> > > }
> > >
> > > +static void update_tx_fqids(struct dpaa2_eth_priv *priv);
> > > +
> >
> > Hi Ioana and Ioana
> >
> > Using forward declarations is generally not liked. Is there something
> > which is preventing you from having it earlier in the file?
>
> Ha! I was just about to ask the same question 😊
>
> +out_err:
> + netdev_info(priv->net_dev,
> + "Error reading Tx FQID, fallback to QDID-based enqueue");
> + priv->enqueue = dpaa2_eth_enqueue_qd;
> +}
>
> Here dpaa2_eth_enqueue_qd is a function pointer which is is defined
> towards the end of the file :S
Hi Jakub
Thanks, i was too lazy to look.
So this is O.K. for net, since fixes should be minimal.
Ioana's please could you submit a patch to net-next, once this has
been merged, to move the code around to remove the forward
declarations.
> Also can I point out that this:
>
> static inline int dpaa2_eth_enqueue_qd(struct dpaa2_eth_priv *priv,
> struct dpaa2_eth_fq *fq,
> struct dpaa2_fd *fd, u8 prio)
> {
> return dpaa2_io_service_enqueue_qd(fq->channel->dpio,
> priv->tx_qdid, prio,
> fq->tx_qdbin, fd);
> }
>
> static inline int dpaa2_eth_enqueue_fq(struct dpaa2_eth_priv *priv,
> struct dpaa2_eth_fq *fq,
> struct dpaa2_fd *fd, u8 prio)
> {
> return dpaa2_io_service_enqueue_fq(fq->channel->dpio,
> fq->tx_fqid[prio], fd);
> }
>
> static void set_enqueue_mode(struct dpaa2_eth_priv *priv)
> {
> if (dpaa2_eth_cmp_dpni_ver(priv, DPNI_ENQUEUE_FQID_VER_MAJOR,
> DPNI_ENQUEUE_FQID_VER_MINOR) < 0)
> priv->enqueue = dpaa2_eth_enqueue_qd;
> else
> priv->enqueue = dpaa2_eth_enqueue_fq;
> }
>
> Could be the most pointless use of the inline keyword possible :)
> Both dpaa2_eth_enqueue_qd() and dpaa2_eth_enqueue_fq() are only ever
> called via a pointer..
Is priv->enqueue used on the hotpath? SPECTRA/Meltdown etc make that
expensive.
Andrew
next prev parent reply other threads:[~2019-10-15 19:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 9:25 [PATCH v2 net 0/2] dpaa2-eth: misc fixes Ioana Ciornei
2019-10-14 9:25 ` [PATCH v2 net 1/2] dpaa2-eth: add irq for the dpmac connect/disconnect event Ioana Ciornei
2019-10-14 9:25 ` [PATCH v2 net 2/2] dpaa2-eth: Fix TX FQID values Ioana Ciornei
2019-10-15 19:29 ` Andrew Lunn
2019-10-15 19:40 ` Jakub Kicinski
2019-10-15 19:47 ` Andrew Lunn [this message]
2019-10-15 20:07 ` Ioana Ciornei
2019-10-15 19:36 ` Jakub Kicinski
2019-10-15 19:58 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015194704.GE7839@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ruxandra.radulescu@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox