From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: linux-kernel@vger•kernel.org
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
stable@vger•kernel.org,
"Geert Uytterhoeven" <geert@linux-m68k•org>,
"Randy Dunlap" <rdunlap@infradead•org>,
"Uwe Kleine-König" <uwe@kleine-koenig•org>,
"Tal Gilboa" <talgi@mellanox•com>,
"Saeed Mahameed" <saeedm@mellanox•com>,
netdev@vger•kernel.org, linux-rdma@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <jakub.kicinski@netronome•com>,
"Doug Ledford" <dledford@redhat•com>,
"Jason Gunthorpe" <jgg@mellanox•com>,
"Leon Romanovsky" <leonro@mellanox•com>,
"Or Gerlitz" <ogerlitz@mellanox•com>,
"Sagi Grimberg" <sagi@grimberg•me>,
"Florian Fainelli" <f.fainelli@gmail•com>
Subject: [PATCH 5.3 090/197] net: ethernet: broadcom: have drivers select DIMLIB as needed
Date: Sun, 27 Oct 2019 22:00:08 +0100 [thread overview]
Message-ID: <20191027203356.604595451@linuxfoundation.org> (raw)
In-Reply-To: <20191027203351.684916567@linuxfoundation.org>
From: Randy Dunlap <rdunlap@infradead•org>
[ Upstream commit ddc790e92b3afa4e366ffb41818cfcd19015031e ]
NET_VENDOR_BROADCOM is intended to control a kconfig menu only.
It should not have anything to do with code generation.
As such, it should not select DIMLIB for all drivers under
NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should
select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET).
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/
Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files")
Reported-by: Geert Uytterhoeven <geert@linux-m68k•org>
Signed-off-by: Randy Dunlap <rdunlap@infradead•org>
Cc: Uwe Kleine-König <uwe@kleine-koenig•org>
Cc: Tal Gilboa <talgi@mellanox•com>
Cc: Saeed Mahameed <saeedm@mellanox•com>
Cc: netdev@vger•kernel.org
Cc: linux-rdma@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>
Cc: Jakub Kicinski <jakub.kicinski@netronome•com>
Cc: Doug Ledford <dledford@redhat•com>
Cc: Jason Gunthorpe <jgg@mellanox•com>
Cc: Leon Romanovsky <leonro@mellanox•com>
Cc: Or Gerlitz <ogerlitz@mellanox•com>
Cc: Sagi Grimberg <sagi@grimberg•me>
Acked-by: Florian Fainelli <f.fainelli@gmail•com>
Reviewed-by: Leon Romanovsky <leonro@mellanox•com>
Signed-off-by: David S. Miller <davem@davemloft•net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
---
drivers/net/ethernet/broadcom/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -8,7 +8,6 @@ config NET_VENDOR_BROADCOM
default y
depends on (SSB_POSSIBLE && HAS_DMA) || PCI || BCM63XX || \
SIBYTE_SB1xxx_SOC
- select DIMLIB
---help---
If you have a network (Ethernet) chipset belonging to this class,
say Y.
@@ -69,6 +68,7 @@ config BCMGENET
select FIXED_PHY
select BCM7XXX_PHY
select MDIO_BCM_UNIMAC
+ select DIMLIB
help
This driver supports the built-in Ethernet MACs found in the
Broadcom BCM7xxx Set Top Box family chipset.
@@ -188,6 +188,7 @@ config SYSTEMPORT
select MII
select PHYLIB
select FIXED_PHY
+ select DIMLIB
help
This driver supports the built-in Ethernet MACs found in the
Broadcom BCM7xxx Set Top Box family chipset using an internal
@@ -200,6 +201,7 @@ config BNXT
select LIBCRC32C
select NET_DEVLINK
select PAGE_POOL
+ select DIMLIB
---help---
This driver supports Broadcom NetXtreme-C/E 10/25/40/50 gigabit
Ethernet cards. To compile this driver as a module, choose M here:
prev parent reply other threads:[~2019-10-27 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191027203351.684916567@linuxfoundation.org>
2019-10-27 20:59 ` [PATCH 5.3 036/197] net: mscc: ocelot: add missing of_node_put after calling of_get_child_by_name Greg Kroah-Hartman
2019-10-27 20:59 ` [PATCH 5.3 037/197] net: dsa: rtl8366rb: " Greg Kroah-Hartman
2019-10-27 20:59 ` [PATCH 5.3 051/197] lib: textsearch: fix escapes in example code Greg Kroah-Hartman
2019-10-27 21:00 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027203356.604595451@linuxfoundation.org \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dledford@redhat$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jgg@mellanox$(echo .)com \
--cc=leonro@mellanox$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=saeedm@mellanox$(echo .)com \
--cc=sagi@grimberg$(echo .)me \
--cc=stable@vger$(echo .)kernel.org \
--cc=talgi@mellanox$(echo .)com \
--cc=uwe@kleine-koenig$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox