From: Jesper Dangaard Brouer <brouer@redhat•com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
Cc: brouer@redhat•com, davem@davemloft•net,
Maciej Fijalkowski <maciej.fijalkowski@intel•com>,
netdev@vger•kernel.org, nhorman@redhat•com, sassmann@redhat•com,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Andrew Bowers <andrewx.bowers@intel•com>
Subject: Re: [net-next v2 9/9] ice: allow 3k MTU for XDP
Date: Tue, 5 Nov 2019 13:37:23 +0100 [thread overview]
Message-ID: <20191105133723.5dbe6aa0@carbon> (raw)
In-Reply-To: <20191104215125.16745-10-jeffrey.t.kirsher@intel.com>
On Mon, 4 Nov 2019 13:51:25 -0800
Jeff Kirsher <jeffrey.t.kirsher@intel•com> wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@intel•com>
>
> At this point ice driver is able to work on order 1 pages that are split
> onto two 3k buffers. Let's reflect that when user is setting new MTU
> size and XDP is present on interface.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel•com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel•com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel•com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 29eea08807fd..363b284e8aa1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -4658,6 +4658,18 @@ static void ice_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type)
> dev_err(dev, "Rebuild failed, unload and reload driver\n");
> }
>
> +/**
> + * ice_max_xdp_frame_size - returns the maximum allowed frame size for XDP
> + * @vsi: Pointer to VSI structure
> + */
> +static int ice_max_xdp_frame_size(struct ice_vsi *vsi)
> +{
> + if (PAGE_SIZE >= 8192 || test_bit(ICE_FLAG_LEGACY_RX, vsi->back->flags))
> + return ICE_RXBUF_2048 - XDP_PACKET_HEADROOM;
I've not checked the details of the ICE drivers memory model, are you
using a split-page model?
If so, in case of ICE_FLAG_LEGACY_RX and PAGE_SIZE==4096, then other
Intel drivers use headroom size 192 bytes and not
XDP_PACKET_HEADROOM=256, because it doesn't fit with split-page model.
Asked in another way: Have you taking into account the 320 bytes needed
by skb_shared_info ?
> + else
> + return ICE_RXBUF_3072;
> +}
> +
> /**
> * ice_change_mtu - NDO callback to change the MTU
> * @netdev: network interface device structure
> @@ -4678,11 +4690,11 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)
> }
>
> if (ice_is_xdp_ena_vsi(vsi)) {
> - int frame_size = ICE_RXBUF_2048 - XDP_PACKET_HEADROOM;
> + int frame_size = ice_max_xdp_frame_size(vsi);
>
> if (new_mtu + ICE_ETH_PKT_HDR_PAD > frame_size) {
> netdev_err(netdev, "max MTU for XDP usage is %d\n",
> - frame_size);
> + frame_size - ICE_ETH_PKT_HDR_PAD);
> return -EINVAL;
> }
> }
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-11-05 12:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 21:51 [net-next v2 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2019-11-04 Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 1/9] ice: Introduce ice_base.c Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 2/9] ice: get rid of per-tc flow in Tx queue configuration routines Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 3/9] ice: Add support for XDP Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 4/9] ice: Move common functions to ice_txrx_lib.c Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 5/9] ice: Add support for AF_XDP Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 6/9] ice: introduce legacy Rx flag Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 7/9] ice: introduce frame padding computation logic Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 8/9] ice: add build_skb() support Jeff Kirsher
2019-11-04 21:51 ` [net-next v2 9/9] ice: allow 3k MTU for XDP Jeff Kirsher
2019-11-05 12:37 ` Jesper Dangaard Brouer [this message]
2019-11-05 17:32 ` Maciej Fijalkowski
2019-11-05 21:40 ` [net-next v2 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2019-11-04 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105133723.5dbe6aa0@carbon \
--to=brouer@redhat$(echo .)com \
--cc=andrewx.bowers@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox