From: Cornelia Huck <cohuck@redhat•com>
To: Jason Wang <jasowang@redhat•com>
Cc: kvm@vger•kernel.org, linux-s390@vger•kernel.org,
linux-kernel@vger•kernel.org, dri-devel@lists•freedesktop.org,
intel-gfx@lists•freedesktop.org,
intel-gvt-dev@lists•freedesktop.org, kwankhede@nvidia•com,
alex.williamson@redhat•com, mst@redhat•com, tiwei.bie@intel•com,
virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, maxime.coquelin@redhat•com,
cunming.liang@intel•com, zhihong.wang@intel•com,
rob.miller@broadcom•com, xiao.w.wang@intel•com,
haotian.wang@sifive•com, zhenyuw@linux•intel.com,
zhi.a.wang@intel•com, jani.nikula@linux•intel.com,
joonas.lahtinen@linux•intel.com, rodrigo.vivi@intel•com,
airlied@linux•ie, daniel@ffwll•ch, farman@linux•ibm.com,
pasic@linux•ibm.com, sebott@linux•ibm.com, oberpar@linux•ibm.com,
heiko.carstens@de•ibm.com, gor@linux•ibm.com,
borntraeger@de•ibm.com, akrowiak@linux•ibm.com,
freude@linux•ibm.com, lingshan.zhu@intel•com, idos@mellanox•com,
eperezma@redhat•com, lulu@redhat•com, parav@mellanox•com,
christophe.de.dinechin@gmail•com, kevin.tian@intel•com,
stefanha@redhat•com
Subject: Re: [PATCH V9 5/6] virtio: introduce a mdev based transport
Date: Wed, 6 Nov 2019 12:00:47 +0100 [thread overview]
Message-ID: <20191106120047.5bcf49c3.cohuck@redhat.com> (raw)
In-Reply-To: <20191106070548.18980-6-jasowang@redhat.com>
On Wed, 6 Nov 2019 15:05:47 +0800
Jason Wang <jasowang@redhat•com> wrote:
> This patch introduces a new mdev transport for virtio. This is used to
> use kernel virtio driver to drive the mediated device that is capable
> of populating virtqueue directly.
>
> A new virtio-mdev driver will be registered to the mdev bus, when a
> new virtio-mdev device is probed, it will register the device with
> mdev based config ops. This means it is a software transport between
> mdev driver and mdev device. The transport was implemented through
> device specific ops which is a part of mdev_parent_ops now.
>
> Signed-off-by: Jason Wang <jasowang@redhat•com>
> ---
> drivers/virtio/Kconfig | 13 ++
> drivers/virtio/Makefile | 1 +
> drivers/virtio/virtio_mdev.c | 406 +++++++++++++++++++++++++++++++++++
> 3 files changed, 420 insertions(+)
> create mode 100644 drivers/virtio/virtio_mdev.c
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 078615cf2afc..558ac607d107 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -43,6 +43,19 @@ config VIRTIO_PCI_LEGACY
>
> If unsure, say Y.
>
> +config VIRTIO_MDEV
> + tristate "MDEV driver for virtio devices"
> + depends on VFIO_MDEV && VIRTIO
> + default n
> + help
> + This driver provides support for virtio based paravirtual
> + device driver over MDEV bus. This requires your environemnt
> + has appropriate virtio mdev device implementation which may
> + operate on the physical device that the datapath of virtio
> + could be offloaded to hardware.
That sentence is a bit confusing to me... what about
"For this to be useful, you need an appropriate virtio mdev device
implementation that operates on a physical device to allow the datapath
of virtio to be offloaded to hardware."
?
> +
> + If unsure, say M
Building this as a module should not hurt (but please add a trailing
'.' here :)
> +
> config VIRTIO_PMEM
> tristate "Support for virtio pmem driver"
> depends on VIRTIO
With the changes above,
Reviewed-by: Cornelia Huck <cohuck@redhat•com>
next prev parent reply other threads:[~2019-11-06 11:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 7:05 [PATCH V9 0/6] mdev based hardware virtio offloading support Jason Wang
2019-11-06 7:05 ` [PATCH V9 1/6] mdev: class id support Jason Wang
2019-11-06 7:05 ` [PATCH V9 2/6] modpost: add support for mdev class id Jason Wang
2019-11-06 7:05 ` [PATCH V9 3/6] mdev: introduce device specific ops Jason Wang
2019-11-06 10:52 ` Cornelia Huck
2019-11-06 7:05 ` [PATCH V9 4/6] mdev: introduce virtio device and its device ops Jason Wang
2019-11-06 10:53 ` Cornelia Huck
2019-11-06 7:05 ` [PATCH V9 5/6] virtio: introduce a mdev based transport Jason Wang
2019-11-06 11:00 ` Cornelia Huck [this message]
2019-11-06 13:11 ` Jason Wang
2019-11-06 7:05 ` [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-11-06 22:50 ` Randy Dunlap
2019-11-06 22:58 ` Alex Williamson
2019-11-07 14:30 ` Jason Wang
2019-11-07 9:01 ` [PATCH V9 0/6] mdev based hardware virtio offloading support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106120047.5bcf49c3.cohuck@redhat.com \
--to=cohuck@redhat$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=akrowiak@linux$(echo .)ibm.com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=christophe.de.dinechin@gmail$(echo .)com \
--cc=cunming.liang@intel$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=eperezma@redhat$(echo .)com \
--cc=farman@linux$(echo .)ibm.com \
--cc=freude@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=haotian.wang@sifive$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=idos@mellanox$(echo .)com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=intel-gvt-dev@lists$(echo .)freedesktop.org \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=jasowang@redhat$(echo .)com \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=kevin.tian@intel$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kwankhede@nvidia$(echo .)com \
--cc=lingshan.zhu@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=lulu@redhat$(echo .)com \
--cc=maxime.coquelin@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oberpar@linux$(echo .)ibm.com \
--cc=parav@mellanox$(echo .)com \
--cc=pasic@linux$(echo .)ibm.com \
--cc=rob.miller@broadcom$(echo .)com \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=sebott@linux$(echo .)ibm.com \
--cc=stefanha@redhat$(echo .)com \
--cc=tiwei.bie@intel$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xiao.w.wang@intel$(echo .)com \
--cc=zhenyuw@linux$(echo .)intel.com \
--cc=zhi.a.wang@intel$(echo .)com \
--cc=zhihong.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox