From: Andrew Lunn <andrew@lunn•ch>
To: Michael Grzeschik <m.grzeschik@pengutronix•de>
Cc: netdev@vger•kernel.org, Tristram.Ha@microchip•com,
UNGLinuxDriver@microchip•com, kernel@pengutronix•de
Subject: Re: [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver
Date: Thu, 7 Nov 2019 16:56:03 +0100 [thread overview]
Message-ID: <20191107155603.GH7344@lunn.ch> (raw)
In-Reply-To: <20191107110030.25199-4-m.grzeschik@pengutronix.de>
> +static const u8 stp_multicast_addr[] = {
> + 0x01, 0x80, 0xC2, 0x00, 0x00, 0x00
> +};
This probably exists already. Please go looking in include/linux and
include/net.
> +static int ksz8863_mdio_read(void *ctx, const void *reg_buf, size_t reg_len,
> + void *val_buf, size_t val_len)
> +{
> + struct ksz_device *dev = (struct ksz_device *)ctx;
ctx is a void *, so you don't need the cast.
> + struct mdio_device *mdev = (struct mdio_device *)dev->priv;
and priv is also probably a void *.
And please fix the reverse christmas tree.
Thanks
Andrew
next prev parent reply other threads:[~2019-11-07 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 11:00 [PATCH v1 0/4] microchip: add support for ksz88x3 driver family Michael Grzeschik
2019-11-07 11:00 ` [PATCH v1 1/4] mdio-bitbang: add SMI0 mode support Michael Grzeschik
2019-11-07 15:42 ` Andrew Lunn
2019-12-18 16:29 ` [PATCH] mdio-bitbang: add support for lowlevel mdio read/write Michael Grzeschik
2019-12-19 20:39 ` Andrew Lunn
2019-12-19 22:01 ` Michael Grzeschik
2019-12-19 22:05 ` Florian Fainelli
2019-12-21 16:41 ` Andrew Lunn
2020-01-29 15:42 ` Michael Grzeschik
2020-01-29 15:53 ` Andrew Lunn
2020-01-29 21:48 ` Michael Grzeschik
2020-04-21 14:31 ` Michael Grzeschik
2019-11-07 11:00 ` [PATCH v1 2/4] net: tag: ksz: Add KSZ8863 tag code Michael Grzeschik
2019-11-07 15:44 ` Andrew Lunn
2019-11-07 11:00 ` [PATCH v1 3/4] ksz: Add Microchip KSZ8863 SMI-DSA driver Michael Grzeschik
2019-11-07 15:56 ` Andrew Lunn [this message]
2019-11-09 8:08 ` kbuild test robot
2019-11-07 11:00 ` [PATCH v1 4/4] dt-bindings: net: dsa: document additional Microchip KSZ8863/8873 switch Michael Grzeschik
2019-11-13 13:34 ` Rob Herring
2019-11-07 15:36 ` [PATCH v1 0/4] microchip: add support for ksz88x3 driver family Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107155603.GH7344@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Tristram.Ha@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=m.grzeschik@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox