Subject: Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to a separate folder

From: Alexandre Belloni <[email-masked]>
Date: Tue, 12 Nov 2019 14:09:47 +0100

Hi,

On 12/11/2019 14:44:18+0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <[email-masked]>
> 
> The vitesse/ folder will contain drivers for switching chips derived
> from legacy Vitesse IPs (VSC family), including those produced by
> Microsemi and Microchip (acquirers of Vitesse).
> 
> Signed-off-by: Vladimir Oltean <[email-masked]>
> ---
>  drivers/net/dsa/Kconfig                       | 31 +------------------
>  drivers/net/dsa/Makefile                      |  4 +--
>  drivers/net/dsa/vitesse/Kconfig               | 31 +++++++++++++++++++
>  drivers/net/dsa/vitesse/Makefile              |  3 ++
>  .../vsc73xx-core.c}                           |  2 +-
>  .../vsc73xx-platform.c}                       |  2 +-
>  .../vsc73xx-spi.c}                            |  2 +-
>  .../{vitesse-vsc73xx.h => vitesse/vsc73xx.h}  |  0
>  8 files changed, 39 insertions(+), 36 deletions(-)
>  create mode 100644 drivers/net/dsa/vitesse/Kconfig
>  create mode 100644 drivers/net/dsa/vitesse/Makefile
>  rename drivers/net/dsa/{vitesse-vsc73xx-core.c => vitesse/vsc73xx-core.c} (99%)
>  rename drivers/net/dsa/{vitesse-vsc73xx-platform.c => vitesse/vsc73xx-platform.c} (99%)
>  rename drivers/net/dsa/{vitesse-vsc73xx-spi.c => vitesse/vsc73xx-spi.c} (99%)
>  rename drivers/net/dsa/{vitesse-vsc73xx.h => vitesse/vsc73xx.h} (100%)
> 

As there are no commonalities between the vsc73xx and felix drivers,
shouldn't you simply leave that one out and have felix in the existing
microchip folder?

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com