Subject: Re: [PATCH net-next 07/12] net: mscc: ocelot: separate the implementation of switch reset

From: Alexandre Belloni <[email-masked]>
Date: Wed, 13 Nov 2019 09:57:59 +0100

On 12/11/2019 15:59:37+0200, Vladimir Oltean wrote:
> On Tue, 12 Nov 2019 at 15:56, Andrew Lunn <[email-masked]> wrote:
> >
> > On Tue, Nov 12, 2019 at 02:44:15PM +0200, Vladimir Oltean wrote:
> > > From: Vladimir Oltean <[email-masked]>
> > >
> > > The Felix switch has a different reset procedure, so a function pointer
> > > needs to be created and added to the ocelot_ops structure.
> > >
> > > The reset procedure has been moved into ocelot_init.
> > >
> > > Signed-off-by: Vladimir Oltean <[email-masked]>
> > > ---
> > >  drivers/net/ethernet/mscc/ocelot.c       |  3 ++
> > >  drivers/net/ethernet/mscc/ocelot.h       |  1 +
> > >  drivers/net/ethernet/mscc/ocelot_board.c | 37 +++++++++++++++---------
> >
> > I'm wondering about the name board. So far, the code you have moved
> > into ocelot_board has nothing to do with the board as such. This is
> > not a GPIO used to reset the switch, it is not a regulator, etc. It is
> > all internal to the device, but just differs per family. Maybe you can
> > think of a better name?
> >
> 
> Alexandre, what do you think? I agree "ocelot_board" is a bit strange.
> 

The name was coming from mscc, Allan agreed to rename it to
ocelot_vsc7514.c which would make sense.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com