Subject: Re: [PATCH net] tcp: switch snprintf to scnprintf

From: Jiri Benc <[email-masked]>
Date: Fri, 15 Nov 2019 10:54:55 +0100

On Fri, 15 Nov 2019 10:41:06 +0800, Hangbin Liu wrote:
> > We need to properly size the output buffers before using them,
> > we can not afford truncating silently the output.
> 
> Yes, I agree. Just as I said, the buffer is still enough, while scnprintf
> is just a safer usage compired with snprintf.

So maybe keep snprintf but add WARN_ON and bail out of the loop if the
buffer size was reached?

	if (WARN_ON(offs >= maxlen))
		break;

 Jiri