Subject: Re: [PATCH net-next v3 2/2] cxgb4: add TC-MATCHALL classifier ingress offload

From: Rahul Lakkireddy <[email-masked]>
Date: Fri, 15 Nov 2019 20:40:47 +0530

On Friday, November 11/15/19, 2019 at 14:53:18 +0100, Jiri Pirko wrote:
> Fri, Nov 15, 2019 at 01:14:21PM CET, [email-masked] wrote:
> 
> [...]
> 
> 
> >@@ -26,9 +37,13 @@ struct cxgb4_tc_matchall {
> > };
> > 
> > int cxgb4_tc_matchall_replace(struct net_device *dev,
> >-			      struct tc_cls_matchall_offload *cls_matchall);
> >+			      struct tc_cls_matchall_offload *cls_matchall,
> >+			      bool ingress);
> > int cxgb4_tc_matchall_destroy(struct net_device *dev,
> >-			      struct tc_cls_matchall_offload *cls_matchall);
> >+			      struct tc_cls_matchall_offload *cls_matchall,
> >+			      bool ingress);
> >+int cxgb4_tc_matchall_stats(struct net_device *dev,
> >+			    struct tc_cls_matchall_offload *cls_matchall);
> 
> Hmm, you only add stats function in this second patch. Does that mean
> you don't care for stats in egress?
> From looking at cxgb_setup_tc_matchall() looks like I'm right.
> Why?
> 

We're currently missing support to fetch these stats from hardware/
firmware on egress side. So, I could only implement it for the ingress
side for now.

> > 
> > int cxgb4_init_tc_matchall(struct adapter *adap);
> > void cxgb4_cleanup_tc_matchall(struct adapter *adap);
> >-- 
> >2.24.0
> >

Thanks,
Rahul