From: Cornelia Huck <cohuck@redhat•com>
To: Jason Wang <jasowang@redhat•com>
Cc: kvm@vger•kernel.org, linux-s390@vger•kernel.org,
linux-kernel@vger•kernel.org, dri-devel@lists•freedesktop.org,
intel-gfx@lists•freedesktop.org,
intel-gvt-dev@lists•freedesktop.org, kwankhede@nvidia•com,
alex.williamson@redhat•com, mst@redhat•com, tiwei.bie@intel•com,
gregkh@linuxfoundation•org, jgg@mellanox•com,
netdev@vger•kernel.org, maxime.coquelin@redhat•com,
cunming.liang@intel•com, zhihong.wang@intel•com,
rob.miller@broadcom•com, xiao.w.wang@intel•com,
haotian.wang@sifive•com, zhenyuw@linux•intel.com,
zhi.a.wang@intel•com, jani.nikula@linux•intel.com,
joonas.lahtinen@linux•intel.com, rodrigo.vivi@intel•com,
airlied@linux•ie, daniel@ffwll•ch, farman@linux•ibm.com,
pasic@linux•ibm.com, sebott@linux•ibm.com, oberpar@linux•ibm.com,
heiko.carstens@de•ibm.com, gor@linux•ibm.com,
borntraeger@de•ibm.com, akrowiak@linux•ibm.com,
freude@linux•ibm.com, lingshan.zhu@intel•com,
eperezma@redhat•com, lulu@redhat•com, parav@mellanox•com,
christophe.de.dinechin@gmail•com, kevin.tian@intel•com,
stefanha@redhat•com, rdunlap@infradead•org, hch@infradead•org,
aadam@redhat•com, jakub.kicinski@netronome•com,
jiri@mellanox•com, jeffrey.t.kirsher@intel•com
Subject: Re: [PATCH V13 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework
Date: Mon, 18 Nov 2019 16:45:10 +0100 [thread overview]
Message-ID: <20191118164510.549c097b.cohuck@redhat.com> (raw)
In-Reply-To: <20191118105923.7991-7-jasowang@redhat.com>
On Mon, 18 Nov 2019 18:59:23 +0800
Jason Wang <jasowang@redhat•com> wrote:
[Note: I have not looked into the reworked architecture of this *at all*
so far; just something that I noted...]
> This sample driver creates mdev device that simulate virtio net device
> over virtio mdev transport. The device is implemented through vringh
> and workqueue. A device specific dma ops is to make sure HVA is used
> directly as the IOVA. This should be sufficient for kernel virtio
> driver to work.
>
> Only 'virtio' type is supported right now. I plan to add 'vhost' type
> on top which requires some virtual IOMMU implemented in this sample
> driver.
>
> Signed-off-by: Jason Wang <jasowang@redhat•com>
> ---
> MAINTAINERS | 1 +
> samples/Kconfig | 10 +
> samples/vfio-mdev/Makefile | 1 +
> samples/vfio-mdev/mvnet_loopback.c | 690 +++++++++++++++++++++++++++++
> 4 files changed, 702 insertions(+)
> create mode 100644 samples/vfio-mdev/mvnet_loopback.c
>
> +static struct mvnet_dev {
> + struct class *vd_class;
> + struct idr vd_idr;
> + struct device dev;
> +} mvnet_dev;
This structure embeds a struct device (a reference-counted structure),
yet it is a static variable. This is giving a bad example to potential
implementers; just allocate it dynamically.
> +static void mvnet_device_release(struct device *dev)
> +{
> + dev_dbg(dev, "mvnet: released\n");
And that also means you need a proper release function here, of
course.
> +}
next prev parent reply other threads:[~2019-11-18 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 10:59 [PATCH V13 0/6] mdev based hardware virtio offloading support Jason Wang
2019-11-18 10:59 ` [PATCH V13 1/6] mdev: make mdev bus agnostic Jason Wang
2019-11-19 3:08 ` Randy Dunlap
2019-11-18 10:59 ` [PATCH V13 2/6] mdev: split out VFIO bus specific parent ops Jason Wang
2019-11-18 10:59 ` [PATCH V13 3/6] mdev: move to drivers/ Jason Wang
2019-11-19 3:11 ` Randy Dunlap
2019-11-18 10:59 ` [PATCH V13 4/6] mdev: introduce mediated virtio bus Jason Wang
2019-11-19 3:13 ` Randy Dunlap
2019-11-18 10:59 ` [PATCH V13 5/6] virtio: introduce a mdev based transport Jason Wang
2019-11-18 10:59 ` [PATCH V13 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-11-18 15:17 ` Greg KH
2019-11-19 3:03 ` Jason Wang
2019-11-18 15:45 ` Cornelia Huck [this message]
2019-11-19 3:04 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118164510.549c097b.cohuck@redhat.com \
--to=cohuck@redhat$(echo .)com \
--cc=aadam@redhat$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=akrowiak@linux$(echo .)ibm.com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=christophe.de.dinechin@gmail$(echo .)com \
--cc=cunming.liang@intel$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=eperezma@redhat$(echo .)com \
--cc=farman@linux$(echo .)ibm.com \
--cc=freude@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haotian.wang@sifive$(echo .)com \
--cc=hch@infradead$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=intel-gvt-dev@lists$(echo .)freedesktop.org \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=jasowang@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jgg@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=kevin.tian@intel$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kwankhede@nvidia$(echo .)com \
--cc=lingshan.zhu@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=lulu@redhat$(echo .)com \
--cc=maxime.coquelin@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oberpar@linux$(echo .)ibm.com \
--cc=parav@mellanox$(echo .)com \
--cc=pasic@linux$(echo .)ibm.com \
--cc=rdunlap@infradead$(echo .)org \
--cc=rob.miller@broadcom$(echo .)com \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=sebott@linux$(echo .)ibm.com \
--cc=stefanha@redhat$(echo .)com \
--cc=tiwei.bie@intel$(echo .)com \
--cc=xiao.w.wang@intel$(echo .)com \
--cc=zhenyuw@linux$(echo .)intel.com \
--cc=zhi.a.wang@intel$(echo .)com \
--cc=zhihong.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox