From: kbuild test robot <lkp@intel•com>
To: Martin Varghese <martinvarghesenokia@gmail•com>
Cc: kbuild-all@lists•01.org, netdev@vger•kernel.org,
davem@davemloft•net, corbet@lwn•net, kuznet@ms2•inr.ac.ru,
yoshfuji@linux-ipv6•org, scott.drennan@nokia•com,
jbenc@redhat•com, martin.varghese@nokia•com
Subject: Re: [PATCH v3 net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.
Date: Wed, 20 Nov 2019 19:10:28 +0800 [thread overview]
Message-ID: <201911201825.LcZpxSwq%lkp@intel.com> (raw)
In-Reply-To: <5acab9e9da8aa9d1e554880b1f548d3057b70b75.1573872263.git.martin.varghese@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 4447 bytes --]
Hi Martin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc8 next-20191120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Martin-Varghese/Bare-UDP-L3-Encapsulation-Module/20191116-135036
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 20021578ba226bda1f0ddf50e4d4a12ea1c6c6c1
config: powerpc-tqm8560_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel•com>
All errors (new ones prefixed by >>):
In file included from include/net/dst_metadata.h:6:0,
from net/core/dev.c:101:
include/net/ip_tunnels.h: In function 'iptunnel_get_v4_rt':
>> include/net/ip_tunnels.h:514:39: error: 'const struct ip_tunnel_info' has no member named 'dst_cache'
dst_cache = (struct dst_cache *)&info->dst_cache;
^~
--
In file included from net/ipv4/ip_tunnel_core.c:26:0:
include/net/ip_tunnels.h: In function 'iptunnel_get_v4_rt':
>> include/net/ip_tunnels.h:514:39: error: 'const struct ip_tunnel_info' has no member named 'dst_cache'
dst_cache = (struct dst_cache *)&info->dst_cache;
^~
In file included from net/ipv4/ip_tunnel_core.c:27:0:
include/net/ip6_tunnel.h: In function 'ip6tunnel_get_dst':
>> include/net/ip6_tunnel.h:191:39: error: 'const struct ip_tunnel_info' has no member named 'dst_cache'
dst_cache = (struct dst_cache *)&info->dst_cache;
^~
>> include/net/ip6_tunnel.h:193:9: error: implicit declaration of function 'dst_cache_get_ip6'; did you mean 'dst_cache_get_ip4'? [-Werror=implicit-function-declaration]
dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
^~~~~~~~~~~~~~~~~
dst_cache_get_ip4
include/net/ip6_tunnel.h:193:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
^
>> include/net/ip6_tunnel.h:209:3: error: implicit declaration of function 'dst_cache_set_ip6'; did you mean 'dst_cache_set_ip4'? [-Werror=implicit-function-declaration]
dst_cache_set_ip6(dst_cache, dst, &fl6->saddr);
^~~~~~~~~~~~~~~~~
dst_cache_set_ip4
cc1: some warnings being treated as errors
vim +514 include/net/ip_tunnels.h
492
493 static inline struct rtable *iptunnel_get_v4_rt(struct sk_buff *skb,
494 struct net_device *dev,
495 struct net *net,
496 struct flowi4 *fl4,
497 const struct ip_tunnel_info *info,
498 bool use_cache)
499 {
500 struct dst_cache *dst_cache;
501 struct rtable *rt = NULL;
502 __u8 tos;
503
504
505 memset(fl4, 0, sizeof(*fl4));
506 fl4->flowi4_mark = skb->mark;
507 fl4->flowi4_proto = IPPROTO_UDP;
508 fl4->daddr = info->key.u.ipv4.dst;
509 fl4->saddr = info->key.u.ipv4.src;
510
511 tos = info->key.tos;
512 fl4->flowi4_tos = RT_TOS(tos);
513
> 514 dst_cache = (struct dst_cache *)&info->dst_cache;
515 if (use_cache) {
516 rt = dst_cache_get_ip4(dst_cache, &fl4->saddr);
517 if (rt)
518 return rt;
519 }
520 rt = ip_route_output_key(net, fl4);
521 if (IS_ERR(rt)) {
522 netdev_dbg(dev, "no route to %pI4\n", &fl4->daddr);
523 return ERR_PTR(-ENETUNREACH);
524 }
525 if (rt->dst.dev == dev) { /* is this necessary? */
526 netdev_dbg(dev, "circular route to %pI4\n", &fl4->daddr);
527 ip_rt_put(rt);
528 return ERR_PTR(-ELOOP);
529 }
530 if (use_cache)
531 dst_cache_set_ip4(dst_cache, &rt->dst, fl4->saddr);
532 return rt;
533 }
534
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 16148 bytes --]
next prev parent reply other threads:[~2019-11-20 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 5:43 [PATCH v3 net-next 0/2] Bare UDP L3 Encapsulation Module Martin Varghese
2019-11-16 5:44 ` [PATCH v3 net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc Martin Varghese
2019-11-18 17:23 ` Willem de Bruijn
2019-11-28 16:24 ` Martin Varghese
2019-11-29 18:18 ` Willem de Bruijn
2019-12-31 15:32 ` Martin Varghese
2020-01-02 19:55 ` Willem de Bruijn
2019-11-20 11:10 ` kbuild test robot [this message]
2019-11-16 5:45 ` [PATCH v3 net-next 2/2] Special handling for IP & MPLS Martin Varghese
2019-11-18 17:30 ` Willem de Bruijn
2019-11-28 16:12 ` Martin Varghese
2019-11-29 18:20 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911201825.LcZpxSwq%lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jbenc@redhat$(echo .)com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=martin.varghese@nokia$(echo .)com \
--cc=martinvarghesenokia@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scott.drennan@nokia$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox