From: Christoph Hellwig <hch@infradead•org>
To: John Hubbard <jhubbard@nvidia•com>
Cc: "Andrew Morton" <akpm@linux-foundation•org>,
"Al Viro" <viro@zeniv•linux.org.uk>,
"Alex Williamson" <alex.williamson@redhat•com>,
"Benjamin Herrenschmidt" <benh@kernel•crashing.org>,
"Björn Töpel" <bjorn.topel@intel•com>,
"Christoph Hellwig" <hch@infradead•org>,
"Dan Williams" <dan.j.williams@intel•com>,
"Daniel Vetter" <daniel@ffwll•ch>,
"Dave Chinner" <david@fromorbit•com>,
"David Airlie" <airlied@linux•ie>,
"David S . Miller" <davem@davemloft•net>,
"Ira Weiny" <ira.weiny@intel•com>, "Jan Kara" <jack@suse•cz>,
"Jason Gunthorpe" <jgg@ziepe•ca>, "Jens Axboe" <axboe@kernel•dk>,
"Jonathan Corbet" <corbet@lwn•net>,
"Jérôme Glisse" <jglisse@redhat•com>,
"Magnus Karlsson" <magnus.karlsson@intel•com>,
"Mauro Carvalho Chehab" <mchehab@kernel•org>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Michal Hocko" <mhocko@suse•com>,
"Mike Kravetz" <mike.kravetz@oracle•com>,
"Paul Mackerras" <paulus@samba•org>,
"Shuah Khan" <shuah@kernel•org>,
"Vlastimil Babka" <vbabka@suse•cz>,
bpf@vger•kernel.org, dri-devel@lists•freedesktop.org,
kvm@vger•kernel.org, linux-block@vger•kernel.org,
linux-doc@vger•kernel.org, linux-fsdevel@vger•kernel.org,
linux-kselftest@vger•kernel.org, linux-media@vger•kernel.org,
linux-rdma@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
netdev@vger•kernel.org, linux-mm@kvack•org,
LKML <linux-kernel@vger•kernel.org>,
"Jason Gunthorpe" <jgg@mellanox•com>
Subject: Re: [PATCH v7 07/24] IB/umem: use get_user_pages_fast() to pin DMA pages
Date: Thu, 21 Nov 2019 00:07:46 -0800 [thread overview]
Message-ID: <20191121080746.GC30991@infradead.org> (raw)
In-Reply-To: <20191121071354.456618-8-jhubbard@nvidia.com>
On Wed, Nov 20, 2019 at 11:13:37PM -0800, John Hubbard wrote:
> And get rid of the mmap_sem calls, as part of that. Note
> that get_user_pages_fast() will, if necessary, fall back to
> __gup_longterm_unlocked(), which takes the mmap_sem as needed.
>
> Reviewed-by: Jan Kara <jack@suse•cz>
> Reviewed-by: Jason Gunthorpe <jgg@mellanox•com>
> Reviewed-by: Ira Weiny <ira.weiny@intel•com>
> Signed-off-by: John Hubbard <jhubbard@nvidia•com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst•de>
Jason, can you queue this up for 5.5 to reduce this patch stack a bit?
next prev parent reply other threads:[~2019-11-21 8:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 7:13 [PATCH v7 00/24] mm/gup: track dma-pinned pages: FOLL_PIN John Hubbard
2019-11-21 7:13 ` [PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions John Hubbard
2019-11-21 8:06 ` Christoph Hellwig
2019-11-21 8:25 ` John Hubbard
2019-11-21 7:13 ` [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines John Hubbard
2019-11-21 8:03 ` Christoph Hellwig
2019-11-21 8:29 ` John Hubbard
2019-11-21 9:49 ` Jan Kara
2019-11-21 21:47 ` John Hubbard
2019-11-21 9:54 ` Jan Kara
2019-11-22 2:54 ` John Hubbard
2019-11-22 11:15 ` Jan Kara
2019-11-21 7:13 ` [PATCH v7 03/24] mm/gup: move try_get_compound_head() to top, fix minor issues John Hubbard
2019-11-21 8:07 ` Christoph Hellwig
2019-11-21 7:13 ` [PATCH v7 04/24] mm: Cleanup __put_devmap_managed_page() vs ->page_free() John Hubbard
2019-11-21 8:04 ` Christoph Hellwig
2019-11-21 7:13 ` [PATCH v7 05/24] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages John Hubbard
2019-11-21 8:05 ` Christoph Hellwig
2019-11-21 8:54 ` John Hubbard
2019-11-21 16:59 ` Dan Williams
2019-11-21 22:22 ` John Hubbard
2019-11-21 7:13 ` [PATCH v7 06/24] goldish_pipe: rename local pin_user_pages() routine John Hubbard
2019-11-21 8:08 ` Christoph Hellwig
2019-11-21 8:36 ` John Hubbard
2019-11-21 7:13 ` [PATCH v7 07/24] IB/umem: use get_user_pages_fast() to pin DMA pages John Hubbard
2019-11-21 8:07 ` Christoph Hellwig [this message]
2019-11-21 14:36 ` Jason Gunthorpe
2019-11-24 6:14 ` John Hubbard
2019-11-24 10:07 ` Leon Romanovsky
2019-11-25 0:05 ` John Hubbard
2019-11-25 0:53 ` Jason Gunthorpe
2019-11-21 7:13 ` [PATCH v7 08/24] media/v4l2-core: set pages dirty upon releasing DMA buffers John Hubbard
2019-11-21 8:09 ` Christoph Hellwig
2019-11-21 7:13 ` [PATCH v7 09/24] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM John Hubbard
2019-11-21 8:10 ` Christoph Hellwig
2019-11-21 8:48 ` John Hubbard
2019-11-21 21:35 ` Alex Williamson
2019-11-21 21:49 ` John Hubbard
2019-11-21 7:13 ` [PATCH v7 10/24] mm/gup: introduce pin_user_pages*() and FOLL_PIN John Hubbard
2019-11-21 7:13 ` [PATCH v7 11/24] goldish_pipe: convert to pin_user_pages() and put_user_page() John Hubbard
2019-11-21 7:13 ` [PATCH v7 12/24] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP John Hubbard
2019-11-21 7:13 ` [PATCH v7 13/24] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() John Hubbard
2019-11-21 7:13 ` [PATCH v7 14/24] drm/via: set FOLL_PIN via pin_user_pages_fast() John Hubbard
2019-11-21 7:13 ` [PATCH v7 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages() John Hubbard
2019-11-21 7:13 ` [PATCH v7 16/24] net/xdp: " John Hubbard
2019-11-21 7:13 ` [PATCH v7 17/24] mm/gup: track FOLL_PIN pages John Hubbard
2019-11-21 9:39 ` Jan Kara
2019-11-30 18:59 ` kbuild test robot
2019-11-21 7:13 ` [PATCH v7 18/24] media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page() conversion John Hubbard
2019-11-21 7:13 ` [PATCH v7 19/24] vfio, mm: " John Hubbard
2019-11-21 7:13 ` [PATCH v7 20/24] powerpc: book3s64: convert to pin_user_pages() and put_user_page() John Hubbard
2019-11-21 7:13 ` [PATCH v7 21/24] mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1" John Hubbard
2019-11-21 7:13 ` [PATCH v7 22/24] mm/gup_benchmark: support pin_user_pages() and related calls John Hubbard
2019-11-21 7:13 ` [PATCH v7 23/24] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage John Hubbard
2019-11-21 7:13 ` [PATCH v7 24/24] mm, tree-wide: rename put_user_page*() to unpin_user_page*() John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121080746.GC30991@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex.williamson@redhat$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bjorn.topel@intel$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=corbet@lwn$(echo .)net \
--cc=dan.j.williams@intel$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=david@fromorbit$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=ira.weiny@intel$(echo .)com \
--cc=jack@suse$(echo .)cz \
--cc=jgg@mellanox$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jglisse@redhat$(echo .)com \
--cc=jhubbard@nvidia$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mhocko@suse$(echo .)com \
--cc=mike.kravetz@oracle$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=vbabka@suse$(echo .)cz \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox