From: Russell King - ARM Linux admin <linux@armlinux•org.uk>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next v2 13/14] net: phy: add Broadcom BCM84881 PHY driver
Date: Tue, 10 Dec 2019 17:58:37 +0000 [thread overview]
Message-ID: <20191210175837.GY25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <557220a9-bdf4-868a-d9cd-a382ae80d288@gmail.com>
On Tue, Dec 10, 2019 at 09:34:16AM -0800, Florian Fainelli wrote:
> On 12/9/19 7:19 AM, Russell King wrote:
> > Add a rudimentary Clause 45 driver for the BCM84881 PHY, found on
> > Methode DM7052 SFPs.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux•org.uk>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail•com>
>
> > ---
> > drivers/net/phy/Kconfig | 6 +
> > drivers/net/phy/Makefile | 1 +
> > drivers/net/phy/bcm84881.c | 269 +++++++++++++++++++++++++++++++++++++
> > 3 files changed, 276 insertions(+)
> > create mode 100644 drivers/net/phy/bcm84881.c
> >
> > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> > index fe602648b99f..41272106dea9 100644
> > --- a/drivers/net/phy/Kconfig
> > +++ b/drivers/net/phy/Kconfig
> > @@ -329,6 +329,12 @@ config BROADCOM_PHY
> > Currently supports the BCM5411, BCM5421, BCM5461, BCM54616S, BCM5464,
> > BCM5481, BCM54810 and BCM5482 PHYs.
> >
> > +config BCM84881_PHY
> > + bool "Broadcom BCM84881 PHY"
> > + depends on PHYLIB=y
> > + ---help---
> > + Support the Broadcom BCM84881 PHY.
>
> Cannot we make this tristate, I believe we cannot until there are more
> fundamental issues (that you just reported) to be fixed, correct?
Indeed. The problem I saw was that although the bcm84881 has the
PHY correctly described, for whatever reason, the module was not
loaded.
What I think is going in is that with modern udev userspace,
request_module() is not functional, and we do not publish the
module IDs for Clause 45 PHYs via uevent. Consequently, there
exists no mechanism to load a Clause 45 PHY driver from the
filesystem.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-12-10 17:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 15:15 [PATCH net-next v2 00/14] Add support for SFP+ copper modules Russell King - ARM Linux admin
2019-12-09 15:18 ` [PATCH net-next v2 01/14] net: sfp: remove incomplete 100BASE-FX and 100BASE-LX support Russell King
2019-12-10 16:52 ` Andrew Lunn
2019-12-09 15:18 ` [PATCH net-next v2 02/14] net: sfp: derive interface mode from ethtool link modes Russell King
2019-12-10 16:53 ` Andrew Lunn
2019-12-09 15:18 ` [PATCH net-next v2 03/14] net: sfp: add more extended compliance codes Russell King
2019-12-10 16:57 ` Andrew Lunn
2019-12-10 17:21 ` Russell King - ARM Linux admin
2019-12-09 15:18 ` [PATCH net-next v2 04/14] net: sfp: add module start/stop upstream notifications Russell King
2019-12-10 16:59 ` Andrew Lunn
2019-12-09 15:18 ` [PATCH net-next v2 05/14] net: sfp: move phy_start()/phy_stop() to phylink Russell King
2019-12-10 17:00 ` Andrew Lunn
2019-12-09 15:18 ` [PATCH net-next v2 06/14] net: mdio-i2c: add support for Clause 45 accesses Russell King
2019-12-10 17:05 ` Andrew Lunn
2019-12-09 15:19 ` [PATCH net-next v2 07/14] net: phylink: re-split __phylink_connect_phy() Russell King
2019-12-10 17:06 ` Andrew Lunn
2019-12-09 15:19 ` [PATCH net-next v2 08/14] net: phylink: support Clause 45 PHYs on SFP+ modules Russell King
2019-12-10 17:07 ` Andrew Lunn
2019-12-09 15:19 ` [PATCH net-next v2 09/14] net: phylink: split link_an_mode configured and current settings Russell King
2019-12-10 17:09 ` Andrew Lunn
2019-12-09 15:19 ` [PATCH net-next v2 10/14] net: phylink: split phylink_sfp_module_insert() Russell King
2019-12-10 17:10 ` Andrew Lunn
2019-12-09 15:19 ` [PATCH net-next v2 11/14] net: phylink: delay MAC configuration for copper SFP modules Russell King
2019-12-10 17:14 ` Andrew Lunn
2019-12-09 15:19 ` [PATCH net-next v2 12/14] net: phylink: make Broadcom BCM84881 based SFPs work Russell King
2019-12-10 17:32 ` Florian Fainelli
2019-12-09 15:19 ` [PATCH net-next v2 13/14] net: phy: add Broadcom BCM84881 PHY driver Russell King
2019-12-10 17:34 ` Florian Fainelli
2019-12-10 17:58 ` Russell King - ARM Linux admin [this message]
2019-12-10 18:46 ` Russell King - ARM Linux admin
2019-12-19 0:55 ` Russell King - ARM Linux admin
2019-12-19 0:57 ` Florian Fainelli
2019-12-09 15:19 ` [PATCH net-next v2 14/14] net: sfp: add support for Clause 45 PHYs Russell King
2019-12-10 17:21 ` Andrew Lunn
2019-12-11 1:23 ` [PATCH net-next v2 00/14] Add support for SFP+ copper modules David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210175837.GY25745@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox