From: Stephen Hemminger <stephen@networkplumber•org>
To: Benjamin Poirier <bpoirier@cumulusnetworks•com>
Cc: netdev@vger•kernel.org, Roopa Prabhu <roopa@cumulusnetworks•com>
Subject: Re: [PATCH iproute2 0/8] bridge vlan tunnelshow fixes
Date: Mon, 16 Dec 2019 20:51:46 -0800 [thread overview]
Message-ID: <20191216205146.3cfd561b@hermes.lan> (raw)
In-Reply-To: <20191216064344.1470824-1-bpoirier@cumulusnetworks.com>
On Mon, 16 Dec 2019 15:43:36 +0900
Benjamin Poirier <bpoirier@cumulusnetworks•com> wrote:
> Fix various problems in and around normal and json output of `bridge vlan
> tunnelshow`.
>
> Can be tested using:
> ip link add bridge type bridge
>
> ip link add vxlan0 type vxlan dstport 4789 external
> ip link set dev vxlan0 master bridge
> ip link set dev vxlan0 type bridge_slave vlan_tunnel on
>
> bridge vlan add dev vxlan0 vid 1000
> bridge vlan add dev vxlan0 vid 1000 tunnel_info id 1000
> bridge vlan add dev vxlan0 vid 1010-1020
> bridge vlan add dev vxlan0 vid 1010-1020 tunnel_info id 1010-1020
> bridge vlan add dev vxlan0 vid 1030
> bridge vlan add dev vxlan0 vid 1030 tunnel_info id 65556
>
> Benjamin Poirier (8):
> json_print: Remove declaration without implementation
> testsuite: Fix line count test
> bridge: Fix typo in error messages
> bridge: Fix src_vni argument in man page
> bridge: Fix BRIDGE_VLAN_TUNNEL attribute sizes
> bridge: Fix vni printing
> bridge: Deduplicate vlan show functions
> bridge: Fix tunnelshow json output
>
> bridge/vlan.c | 138 ++++++++---------------
> include/json_print.h | 2 -
> man/man8/bridge.8 | 4 +-
> testsuite/Makefile | 3 +-
> testsuite/lib/generic.sh | 8 +-
> testsuite/tests/bridge/vlan/tunnelshow.t | 33 ++++++
> 6 files changed, 88 insertions(+), 100 deletions(-)
> create mode 100755 testsuite/tests/bridge/vlan/tunnelshow.t
>
Thanks for cleaning this up. Applied
prev parent reply other threads:[~2019-12-17 4:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 6:43 [PATCH iproute2 0/8] bridge vlan tunnelshow fixes Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 1/8] json_print: Remove declaration without implementation Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 2/8] testsuite: Fix line count test Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 3/8] bridge: Fix typo in error messages Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 4/8] bridge: Fix src_vni argument in man page Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 5/8] bridge: Fix BRIDGE_VLAN_TUNNEL attribute sizes Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 6/8] bridge: Fix vni printing Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 7/8] bridge: Deduplicate vlan show functions Benjamin Poirier
2019-12-16 6:43 ` [PATCH iproute2 8/8] bridge: Fix tunnelshow json output Benjamin Poirier
2019-12-17 4:51 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216205146.3cfd561b@hermes.lan \
--to=stephen@networkplumber$(echo .)org \
--cc=bpoirier@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox