Subject: Re: [PATCH v5 5/5] net: dsa: add support for Atheros AR9331 built-in switch

From: Andrew Lunn <[email-masked]>
Date: Tue, 17 Dec 2019 09:55:58 +0100

On Mon, Dec 16, 2019 at 08:44:03AM +0100, Oleksij Rempel wrote:
> Provide basic support for Atheros AR9331 built-in switch. So far it
> works as port multiplexer without any hardware offloading support.
> 
> Signed-off-by: Oleksij Rempel <[email-masked]>
> +
> +/* dummy reg to change page */
> +#define AR9331_SW_REG_PAGE			BIT(18)

Nit pick: It seems odd to define a register number using a BIT macro.

Reviewed-by: Andrew Lunn <[email-masked]>

    Andrew