From: 'Greg KH' <gregkh@linuxfoundation•org>
To: "Saleem, Shiraz" <shiraz.saleem@intel•com>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"nhorman@redhat•com" <nhorman@redhat•com>,
"sassmann@redhat•com" <sassmann@redhat•com>,
"jgg@ziepe•ca" <jgg@ziepe•ca>,
"parav@mellanox•com" <parav@mellanox•com>,
"Ismail, Mustafa" <mustafa.ismail@intel•com>
Subject: Re: [PATCH v3 04/20] i40e: Register a virtbus device to provide RDMA
Date: Thu, 19 Dec 2019 09:46:14 +0100 [thread overview]
Message-ID: <20191219084614.GC1027830@kroah.com> (raw)
In-Reply-To: <9DD61F30A802C4429A01CA4200E302A7B6B9AFF7@fmsmsx124.amr.corp.intel.com>
On Wed, Dec 18, 2019 at 06:57:10PM +0000, Saleem, Shiraz wrote:
> > > > Subject: Re: [PATCH v3 04/20] i40e: Register a virtbus device to
> > > > provide RDMA
> [.....]
>
> > > >
> > > > And who owns the memory of this thing that is supposed to be
> > > > dynamically controlled by something OUTSIDE of this driver? Who
> > > > created that thing 3 pointers deep? What happens when you leak the
> > > > memory below (hint, you did), and who is supposed to clean it up if
> > > > you need to properly clean it up if something bad happens?
> > >
> > > The i40e_info object memory is tied to the PF driver.
> >
> > What is a "PF"?
>
> physical function.
>
> >
> > > The object hierarchy is,
> > >
> > > i40e_pf: pointer to i40e_client_instance
> > > ----- i40e_client_instance: i40e_info
> > > ----- i40e_info: virtbus_device
> >
> > So you are 3 pointers deep to get a structure that is dynamically controlled? Why
> > are those "3 pointers" not also represented in sysfs?
> > You have a heiarchy within the kernel that is not being represented that way to
> > userspace, why?
> >
> > Hint, I think this is totally wrong, you need to rework this to be sane.
> >
> > > For each PF, there is a client_instance object allocated.
> >
> > Great, make it dynamic and in the device tree.
> >
> > > The i40e_info object is populated and the virtbus_device hanging off this object
> > is registered.
> >
> > Great, make that dynamic and inthe device tree.
> >
> > If you think this is too much, then your whole mess here is too much and needs to
> > be made a lot simpler.
> >
>
> I think we can decouple the virtbus_device object from i40e_info object.
>
> Instead allocate a i40e_virtbus_device object which contains
> the virtbus_device and a pointer to i40e_info object for the
> RDMA driver to consume on probe(). Register it the virtbus, and provide
> a release callback to free up its memory.
>
> Sending a patch snippet to hopefully make it clearer.
Yes, this looks a little bit more sane.
greg k-h
next prev parent reply other threads:[~2019-12-19 8:46 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 22:49 [net-next v3 00/20][pull request] Intel Wired LAN Driver Updates 2019-12-09 Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 01/20] virtual-bus: Implementation of Virtual Bus Jeff Kirsher
2019-12-10 6:49 ` Leon Romanovsky
2019-12-10 17:51 ` Jason Gunthorpe
2019-12-10 15:20 ` Greg KH
2019-12-10 18:22 ` Jason Gunthorpe
2019-12-09 22:49 ` [PATCH v3 02/20] ice: Initialize and register a virtual bus to provide RDMA Jeff Kirsher
2019-12-10 15:32 ` Greg KH
2019-12-23 19:06 ` Allan, Bruce W
2019-12-09 22:49 ` [PATCH v3 03/20] ice: Implement peer communications Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 04/20] i40e: Register a virtbus device to provide RDMA Jeff Kirsher
2019-12-10 15:33 ` Greg KH
2019-12-10 15:39 ` Greg KH
2019-12-13 23:08 ` Saleem, Shiraz
2019-12-14 8:37 ` Greg KH
2019-12-18 18:57 ` Saleem, Shiraz
2019-12-18 19:20 ` Jason Gunthorpe
2020-01-02 16:01 ` Saleem, Shiraz
2019-12-19 8:46 ` 'Greg KH' [this message]
2019-12-16 3:48 ` Parav Pandit
2019-12-16 7:15 ` Greg KH
2019-12-16 8:36 ` Parav Pandit
2019-12-16 8:58 ` Greg KH
2019-12-16 9:17 ` Parav Pandit
2019-12-09 22:49 ` [PATCH v3 05/20] RDMA/irdma: Add driver framework definitions Jeff Kirsher
2019-12-10 19:04 ` Jason Gunthorpe
2019-12-11 6:07 ` Leon Romanovsky
2019-12-12 1:40 ` Saleem, Shiraz
2019-12-12 8:39 ` Leon Romanovsky
2019-12-12 9:12 ` gregkh
2019-12-17 21:00 ` Jason Gunthorpe
2019-12-21 0:00 ` Keller, Jacob E
2019-12-09 22:49 ` [PATCH v3 06/20] RDMA/irdma: Implement device initialization definitions Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 07/20] RDMA/irdma: Implement HW Admin Queue OPs Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 08/20] RDMA/irdma: Add HMC backing store setup functions Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 09/20] RDMA/irdma: Add privileged UDA queue implementation Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 10/20] RDMA/irdma: Add QoS definitions Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 11/20] RDMA/irdma: Add connection manager Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 12/20] RDMA/irdma: Add PBLE resource manager Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 13/20] RDMA/irdma: Implement device supported verb APIs Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 14/20] RDMA/irdma: Add RoCEv2 UD OP support Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 15/20] RDMA/irdma: Add user/kernel shared libraries Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 16/20] RDMA/irdma: Add miscellaneous utility definitions Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 17/20] RDMA/irdma: Add dynamic tracing for CM Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 18/20] RDMA/irdma: Add ABI definitions Jeff Kirsher
2019-12-09 22:49 ` [PATCH v3 19/20] RDMA: Add irdma Kconfig/Makefile and remove i40iw Jeff Kirsher
2019-12-11 20:02 ` Jason Gunthorpe
2019-12-13 23:06 ` Saleem, Shiraz
2019-12-17 21:04 ` Jason Gunthorpe
2020-01-02 16:00 ` Saleem, Shiraz
2020-01-02 17:04 ` Jason Gunthorpe
2020-01-02 17:50 ` Saleem, Shiraz
2020-01-02 18:06 ` Jason Gunthorpe
2019-12-09 22:49 ` [PATCH v3 20/20] RDMA/irdma: Update MAINTAINERS file Jeff Kirsher
2019-12-10 7:33 ` [net-next v3 00/20][pull request] Intel Wired LAN Driver Updates 2019-12-09 Greg KH
2019-12-10 17:22 ` Jason Gunthorpe
2019-12-10 18:06 ` Jeff Kirsher
2019-12-10 18:25 ` Jason Gunthorpe
2019-12-10 18:41 ` Jeff Kirsher
2019-12-10 19:11 ` Jason Gunthorpe
2019-12-10 19:23 ` Jeff Kirsher
2019-12-10 19:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219084614.GC1027830@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=mustafa.ismail@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=parav@mellanox$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
--cc=shiraz.saleem@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox