Subject: Re: [PATCH V8 net-next 06/12] net: phy: dp83640: Move the probe and remove methods around.

From: Andrew Lunn <[email-masked]>
Date: Mon, 23 Dec 2019 10:12:05 +0100

On Sat, Dec 21, 2019 at 11:36:32AM -0800, Richard Cochran wrote:
> An upcoming patch will change how the PHY time stamping functions are
> registered with the networking stack, and adapting this driver would
> entail adding forward declarations for four time stamping methods.
> However, forward declarations are considered to be stylistic defects.
> This patch avoids the issue by moving the probe and remove methods
> immediately above the phy_driver interface structure.
> 
> Signed-off-by: Richard Cochran <[email-masked]>

Hi Richard

Thanks for adding this.

Reviewed-by: Andrew Lunn <[email-masked]>

    Andrew