From: "Michael S. Tsirkin" <mst@redhat•com>
To: Jesper Dangaard Brouer <brouer@redhat•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Jason Wang <jasowang@redhat•com>
Subject: Re: [PATCH net-next] ptr_ring: add include of linux/mm.h
Date: Mon, 13 Jan 2020 08:16:50 -0500 [thread overview]
Message-ID: <20200113081641-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <157891093662.53334.15580647502551818360.stgit@firesoul>
On Mon, Jan 13, 2020 at 11:22:16AM +0100, Jesper Dangaard Brouer wrote:
> Commit 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> started to use kvmalloc_array and kvfree, which are defined in mm.h,
> the previous functions kcalloc and kfree, which are defined in slab.h.
>
> Add the missing include of linux/mm.h. This went unnoticed as other
> include files happened to include mm.h.
>
> Fixes: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat•com>
Acked-by: Michael S. Tsirkin <mst@redhat•com>
> ---
> include/linux/ptr_ring.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
> index 0abe9a4fc842..417db0a79a62 100644
> --- a/include/linux/ptr_ring.h
> +++ b/include/linux/ptr_ring.h
> @@ -23,6 +23,7 @@
> #include <linux/types.h>
> #include <linux/compiler.h>
> #include <linux/slab.h>
> +#include <linux/mm.h>
> #include <asm/errno.h>
> #endif
>
>
next prev parent reply other threads:[~2020-01-13 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 10:22 [PATCH net-next] ptr_ring: add include of linux/mm.h Jesper Dangaard Brouer
2020-01-13 13:16 ` Michael S. Tsirkin [this message]
2020-01-14 2:19 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113081641-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=brouer@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jasowang@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox