Subject: Re: [PATCH net-next] net: phylink: allow in-band AN for USXGMII

From: Russell King - ARM Linux admin <[email-masked]>
Date: Sat, 18 Jan 2020 10:53:25 +0000

On Thu, Jan 16, 2020 at 07:39:30PM +0200, Vladimir Oltean wrote:
> From: Alex Marginean <[email-masked]>
> 
> USXGMII supports passing link information in-band between PHY and MAC PCS,
> add it to the list of protocols that support in-band AN mode.
> 
> Being a MAC-PHY protocol that can auto-negotiate link speeds up to 10
> Gbps, we populate the initial supported mask with the entire spectrum of
> link modes up to 10G that PHYLINK supports, and we let the driver reduce
> that mask in its .phylink_validate method.
> 
> Signed-off-by: Alex Marginean <[email-masked]>
> Signed-off-by: Vladimir Oltean <[email-masked]>

Please copy your patches to the netdev mailing list.

> ---
>  drivers/net/phy/phylink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index efabbfa4a6d3..f40d92ec32f8 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -299,6 +299,7 @@ static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
>  			break;
>  
>  		case PHY_INTERFACE_MODE_10GKR:
> +		case PHY_INTERFACE_MODE_USXGMII:
>  		case PHY_INTERFACE_MODE_10GBASER:

Please also move USXGMII before 10GKR.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up