From: Ido Schimmel <idosch@idosch•org>
To: Christophe JAILLET <christophe.jaillet@wanadoo•fr>
Cc: jiri@mellanox•com, idosch@mellanox•com, davem@davemloft•net,
vadimp@mellanox•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: Re: [PATCH] mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()'
Date: Sun, 26 Jan 2020 10:19:41 +0200 [thread overview]
Message-ID: <20200126081941.GA794072@splinter> (raw)
In-Reply-To: <20200125211847.12755-1-christophe.jaillet@wanadoo.fr>
On Sat, Jan 25, 2020 at 10:18:47PM +0100, Christophe JAILLET wrote:
> An 'alloc_etherdev()' called is not ballanced by a corresponding
> 'free_netdev()' call in one error handling path.
>
> Slighly reorder the error handling code to catch the missed case.
>
> Fixes: c100e47caa8e ("mlxsw: minimal: Add ethtool support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo•fr>
For net:
Reviewed-by: Ido Schimmel <idosch@mellanox•com>
Thanks!
next prev parent reply other threads:[~2020-01-26 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 21:18 [PATCH] mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()' Christophe JAILLET
2020-01-26 8:19 ` Ido Schimmel [this message]
2020-01-27 10:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126081941.GA794072@splinter \
--to=idosch@idosch$(echo .)org \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vadimp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox