Subject: Re: [PATCH v2 net 1/5] icmp: introduce helper for NAT'd source address in network device context

From: Florian Westphal <[email-masked]>
Date: Mon, 10 Feb 2020 22:32:59 +0100

Jason A. Donenfeld <[email-masked]> wrote:
> On Mon, Feb 10, 2020 at 3:15 PM Jason A. Donenfeld <[email-masked]> wrote:
> > +               ip_hdr(skb_in)->saddr = ct->tuplehash[0].tuple.src.u3.ip;
> > +       }
> > +       icmp_send(skb_in, type, code, info);
> 
> According to the comments in icmp_send, access to
> ip_hdr(skb_in)->saddr requires first checking for `if
> (skb_network_header(skb_in) < skb_in->head ||
> (skb_network_header(skb_in) + sizeof(struct iphdr)) >
> skb_tail_pointer(skb_in))` first to be safe.

You will probably also need skb_ensure_writable() to handle cloned skbs.

I also suggest to check "ct->status & IPS_NAT_MASK", nat is only done if
those bits are set.