From: Jason Gunthorpe <jgg@mellanox•com>
To: Jason Wang <jasowang@redhat•com>
Cc: "mst@redhat•com" <mst@redhat•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"kvm@vger•kernel.org" <kvm@vger•kernel.org>,
"virtualization@lists•linux-foundation.org"
<virtualization@lists•linux-foundation.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"tiwei.bie@intel•com" <tiwei.bie@intel•com>,
"maxime.coquelin@redhat•com" <maxime.coquelin@redhat•com>,
"cunming.liang@intel•com" <cunming.liang@intel•com>,
"zhihong.wang@intel•com" <zhihong.wang@intel•com>,
"rob.miller@broadcom•com" <rob.miller@broadcom•com>,
"xiao.w.wang@intel•com" <xiao.w.wang@intel•com>,
"haotian.wang@sifive•com" <haotian.wang@sifive•com>,
"lingshan.zhu@intel•com" <lingshan.zhu@intel•com>,
"eperezma@redhat•com" <eperezma@redhat•com>,
"lulu@redhat•com" <lulu@redhat•com>,
Parav Pandit <parav@mellanox•com>,
"kevin.tian@intel•com" <kevin.tian@intel•com>,
"stefanha@redhat•com" <stefanha@redhat•com>,
"rdunlap@infradead•org" <rdunlap@infradead•org>,
"hch@infradead•org" <hch@infradead•org>,
"aadam@redhat•com" <aadam@redhat•com>,
Jiri Pirko <jiri@mellanox•com>,
Shahaf Shuler <shahafs@mellanox•com>,
"hanand@xilinx•com" <hanand@xilinx•com>,
"mhabets@solarflare•com" <mhabets@solarflare•com>
Subject: Re: [PATCH V4 4/5] virtio: introduce a vDPA based transport
Date: Thu, 20 Feb 2020 15:19:18 +0000 [thread overview]
Message-ID: <20200220151914.GW23930@mellanox.com> (raw)
In-Reply-To: <20200220061141.29390-5-jasowang@redhat.com>
On Thu, Feb 20, 2020 at 02:11:40PM +0800, Jason Wang wrote:
> +static int virtio_vdpa_probe(struct vdpa_device *vdpa)
> +{
> + const struct vdpa_config_ops *ops = vdpa->config;
> + struct virtio_vdpa_device *vd_dev;
> + int ret = -EINVAL;
> +
> + vd_dev = kzalloc(sizeof(*vd_dev), GFP_KERNEL);
> + if (!vd_dev)
> + return -ENOMEM;
> +
> + vd_dev->vdev.dev.parent = vdpa_get_dma_dev(vdpa);
> + vd_dev->vdev.dev.release = virtio_vdpa_release_dev;
> + vd_dev->vdev.config = &virtio_vdpa_config_ops;
> + vd_dev->vdpa = vdpa;
> + INIT_LIST_HEAD(&vd_dev->virtqueues);
> + spin_lock_init(&vd_dev->lock);
> +
> + vd_dev->vdev.id.device = ops->get_device_id(vdpa);
> + if (vd_dev->vdev.id.device == 0)
> + goto err;
> +
> + vd_dev->vdev.id.vendor = ops->get_vendor_id(vdpa);
> + ret = register_virtio_device(&vd_dev->vdev);
> + if (ret)
> + goto err;
This error unwind is wrong. register_virtio_device() does
device_initialize() as it's first action. After that point error
unwind must be done with put_device() - particularly calling
kfree(vd_dev) after doing dev_set_name() leaks memory.
Looks like about half of the register_virtio_device() users did this
right, the others not. Perhaps you should fix them too...
Jason
next prev parent reply other threads:[~2020-02-20 15:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 6:11 [PATCH V4 0/5] vDPA support Jason Wang
2020-02-20 6:11 ` [PATCH V4 1/5] vhost: factor out IOTLB Jason Wang
2020-02-20 6:11 ` [PATCH V4 2/5] vringh: IOTLB support Jason Wang
2020-02-20 6:11 ` [PATCH V4 3/5] vDPA: introduce vDPA bus Jason Wang
2020-02-20 15:14 ` Jason Gunthorpe
2020-02-21 7:54 ` Jason Wang
2020-02-24 6:14 ` Harpreet Singh Anand
2020-02-24 6:48 ` Jason Wang
2020-02-20 6:11 ` [PATCH V4 4/5] virtio: introduce a vDPA based transport Jason Wang
2020-02-20 15:19 ` Jason Gunthorpe [this message]
2020-02-21 8:06 ` Jason Wang
2020-02-20 6:11 ` [PATCH V4 5/5] vdpasim: vDPA device simulator Jason Wang
2020-02-20 15:12 ` Jason Gunthorpe
2020-02-21 7:57 ` Jason Wang
2020-02-26 6:12 ` Jason Wang
2020-02-26 17:19 ` Jason Gunthorpe
2020-02-21 8:33 ` Harpreet Singh Anand
2020-02-21 8:50 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220151914.GW23930@mellanox.com \
--to=jgg@mellanox$(echo .)com \
--cc=aadam@redhat$(echo .)com \
--cc=cunming.liang@intel$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=hanand@xilinx$(echo .)com \
--cc=haotian.wang@sifive$(echo .)com \
--cc=hch@infradead$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=kevin.tian@intel$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=lingshan.zhu@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lulu@redhat$(echo .)com \
--cc=maxime.coquelin@redhat$(echo .)com \
--cc=mhabets@solarflare$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=parav@mellanox$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=rob.miller@broadcom$(echo .)com \
--cc=shahafs@mellanox$(echo .)com \
--cc=stefanha@redhat$(echo .)com \
--cc=tiwei.bie@intel$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xiao.w.wang@intel$(echo .)com \
--cc=zhihong.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox