Subject: Re: [PATCH RFC net-next] virtio_net: Relax queue requirement for using XDP

From: "Michael S. Tsirkin" <[email-masked]>
Date: Wed, 26 Feb 2020 04:32:47 -0500

On Wed, Feb 26, 2020 at 10:02:03AM +0100, Toke Høiland-Jørgensen wrote:
> "Michael S. Tsirkin" <[email-masked]> writes:
> 
> > On Wed, Feb 26, 2020 at 09:34:51AM +0100, Toke Høiland-Jørgensen wrote:
> >> we already do block some reconfiguration if an XDP program is loaded
> >> (such as MTU changes), so there is some precedence for that :)
> > Do we really block MTU changes when XDP is loaded?
> > Seems to work for me - there's a separate discussion going
> > on about how to handle MTU changes - see
> > https://lore.kernel.org/r/[email-masked]
> > 	virtio_net: can change MTU after installing program
> 
> Maybe not for virtio_net, but that same thing doesn't work on mlx5:
> 
> $ sudo ip link set dev ens1f1 mtu 8192
> RTNETLINK answers: Invalid argument
> 
> -Toke

Let's take it to that thread please. I'll CC you.

-- 
MST