public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andrew Lunn <andrew@lunn•ch>
To: Russell King - ARM Linux admin <linux@armlinux•org.uk>
Cc: Rob Herring <robh+dt@kernel•org>,
	Florian Fainelli <f.fainelli@gmail•com>,
	Heiner Kallweit <hkallweit1@gmail•com>,
	"David S. Miller" <davem@davemloft•net>,
	devicetree@vger•kernel.org, Jason Cooper <jason@lakedaemon•net>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists•infradead.org>,
	Mark Rutland <mark.rutland@arm•com>,
	netdev <netdev@vger•kernel.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver
Date: Thu, 27 Feb 2020 18:36:36 +0100	[thread overview]
Message-ID: <20200227173636.GE5245@lunn.ch> (raw)
In-Reply-To: <20200227172608.GO25745@shell.armlinux.org.uk>

> > > +    allOf:
> > > +      - $ref: /schemas/types.yaml#/definitions/uint16-array
> > > +      - minItems: 1
> > > +        maxItems: 4
> > > +
> > > +examples:
> > > +  - |
> > > +    ethernet-phy@0 {
> > > +        reg = <0>;
> > 
> > This needs to be under an 'mdio' node with #address-cells and
> > #size-cells set correctly.
> 
> I wish these things were documented somewhere... I'm pretty sure this
> passed validation when I wrote it.

Documentation/devicetree/bindings/net/mdio.yaml

Rob, is there a way to express the hierarchy between yaml files and
properties? Can we say that a phy, as defined by ethernet-phy.yaml
should always be inside an MDIO bus as defined in mdio.yaml?

Thanks
	Andrew

next prev parent reply	other threads:[~2020-02-27 17:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  9:51 [PATCH net-next 0/3] Add support for configuring Marvell 10G PHY LEDs Russell King - ARM Linux admin
2020-02-27  9:52 ` [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver Russell King
2020-02-27 17:08   ` Rob Herring
2020-02-27 17:14     ` Russell King - ARM Linux admin
2020-02-27 17:13   ` Rob Herring
2020-02-27 17:26     ` Russell King - ARM Linux admin
2020-02-27 17:36       ` Andrew Lunn [this message]
2020-02-27 17:40         ` Russell King - ARM Linux admin
2020-02-27 20:11         ` Rob Herring
2020-02-27 17:44   ` Florian Fainelli
2020-02-27 18:59     ` Russell King - ARM Linux admin
2020-02-27  9:52 ` [PATCH net-next 2/3] net: phy: marvell10g: add support for configuring LEDs Russell King
2020-02-27  9:52 ` [PATCH net-next 3/3] arm64: dts: configure Macchiatobin 10G PHY LED modes Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227173636.GE5245@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=hkallweit1@gmail$(echo .)com \
    --cc=jason@lakedaemon$(echo .)net \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux@armlinux$(echo .)org.uk \
    --cc=mark.rutland@arm$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=robh+dt@kernel$(echo .)org \
    --cc=sebastian.hesselbarth@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox