Subject: Re: [PATCH] drivers/of/of_mdio.c:fix of_mdiobus_register()

From: Russell King - ARM Linux admin <[email-masked]>
Date: Mon, 2 Mar 2020 18:38:33 +0000

On Mon, Mar 02, 2020 at 06:57:59PM +0100, Andrew Lunn wrote:
> Hi Dajun
> 
> > This is my test in Xilinx zcu106 board.
> > 
> > dts is liks this:
> > ethernet@ff0e0000 {
> >     compatible = "cdns,zynqmp-gem", "cdns,gem";
> >     status = "okay";
> >     ...
> >     
> >     phy@0 {
> >         ti,rx-internal-delay = <0x8>;
> >         ti,tx-internal-delay = <0xa>;
> >         ti,fifo-depth = <0x1>;
> >         ti,rxctrl-strap-worka;
> >         linux,phandle = <0x12>;
> >         phandle = <0x12>;

Isn't dtc going to complain about this?  The node name has an address,
but there's no reg property.  If there's no reg property, shouldn't it
be just "phy" ?

The above doesn't look like the original .dts file itself either, but
a .dtb translated back to a .dts - note the numeric phandle properties
and presence of "linux,phandle".

ethernet-phy.yaml also says:

required:
  - reg

so arguably the above doesn't conform to what we expect?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up